Create components when we actually have a profile

RESOLVED FIXED in mozilla1.9.1b1

Status

()

Toolkit
Startup and Profile System
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.1b1
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
xpcom-startup and app-startup happen to early, and you aren't given a profile.  Currently, anyone who needs a profile has to be created then, and then register an observer for profile-after-change.  We can simplify this by just creating them if they register with the category manager at this time.
(Assignee)

Comment 1

9 years ago
Created attachment 335773 [details] [diff] [review]
v1.0

This does the trick, but I'm not sure if it's what bsmedberg is going to want.
Attachment #335773 - Flags: review?(benjamin)
(Assignee)

Updated

9 years ago
Whiteboard: [has patch][needs review bsmedberg]
Not particularly wanting notification proliferation, but I wonder if a different named notification would be better to separate out the ways you register for it?
Keywords: dev-doc-needed

Updated

9 years ago
Attachment #335773 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> Not particularly wanting notification proliferation, but I wonder if a
> different named notification would be better to separate out the ways you
> register for it?
I'm going to assume that bsmedberg doesn't think it matters either way?
Whiteboard: [has patch][needs review bsmedberg] → [has patch][has review][can land]

Comment 4

9 years ago
I prefer to keep the names the same, actually.
(Assignee)

Comment 5

9 years ago
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/7a679b9335f3
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
Added a note about this here:

https://developer.mozilla.org/en/Observer_Notifications#Application_startup
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.