Closed
Bug 452486
Opened 16 years ago
Closed 16 years ago
Create components when we actually have a profile
Categories
(Toolkit :: Startup and Profile System, defect)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
1.41 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
xpcom-startup and app-startup happen to early, and you aren't given a profile. Currently, anyone who needs a profile has to be created then, and then register an observer for profile-after-change. We can simplify this by just creating them if they register with the category manager at this time.
Assignee | ||
Comment 1•16 years ago
|
||
This does the trick, but I'm not sure if it's what bsmedberg is going to want.
Attachment #335773 -
Flags: review?(benjamin)
Assignee | ||
Updated•16 years ago
|
Whiteboard: [has patch][needs review bsmedberg]
Comment 2•16 years ago
|
||
Not particularly wanting notification proliferation, but I wonder if a different named notification would be better to separate out the ways you register for it?
Keywords: dev-doc-needed
Updated•16 years ago
|
Attachment #335773 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•16 years ago
|
||
(In reply to comment #2)
> Not particularly wanting notification proliferation, but I wonder if a
> different named notification would be better to separate out the ways you
> register for it?
I'm going to assume that bsmedberg doesn't think it matters either way?
Whiteboard: [has patch][needs review bsmedberg] → [has patch][has review][can land]
Comment 4•16 years ago
|
||
I prefer to keep the names the same, actually.
Assignee | ||
Comment 5•16 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/7a679b9335f3
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
Comment 6•16 years ago
|
||
Added a note about this here:
https://developer.mozilla.org/en/Observer_Notifications#Application_startup
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•