452504 - port bug 97954, bug 394901, bug 451466, and bug 450194 changes to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Robert Kaiser]

bug 97954 - autoconf build environment for spidermonkey
http://hg.mozilla.org/mozilla-central/index.cgi/rev/661c6de0b8f0

We have ported the aclocal.m4 changes but there's more in client.mk and rules.mk that we should port.

More changes we need to port are in those bugs/changesets:

bug 394901 - make nsIUserInfo implementation on mac work, and modernize it
http://hg.mozilla.org/mozilla-central/index.cgi/rev/9ad2f77e6778

bug 451466 - wget target to get en-US binary
http://hg.mozilla.org/mozilla-central/index.cgi/rev/25b909ce268c

bug 450194 - Add -Wno-invalid-offsetof to our warnings flags, because we break the rules on purpose
http://hg.mozilla.org/mozilla-central/index.cgi/rev/41d9d32ab5a7

Comment 1

[Robert Kaiser]

(In reply to comment #0)
> bug 394901 - make nsIUserInfo implementation on mac work, and modernize it
> http://hg.mozilla.org/mozilla-central/index.cgi/rev/9ad2f77e6778

http://hg.mozilla.org/mozilla-central/index.cgi/diff/9ad2f77e6778/configure.in may not need to be ported actually.

Comment 2

[Robert Kaiser]

Attachment: patch to port all those changes to comm-central

Here's the patch for porting all the mentioned changes to comm-central.

Comment 3

[Robert Kaiser]

We probably want the full bug 451466 for SeaMonkey, I'll do that either in an additional patch or as a followup.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> We probably want the full bug 451466 for SeaMonkey, I'll do that either in an
> additional patch or as a followup.

We'll need it for TB as well, but I can always cover that elsewhere.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #1)
> (In reply to comment #0)
> > bug 394901 - make nsIUserInfo implementation on mac work, and modernize it
> > http://hg.mozilla.org/mozilla-central/index.cgi/rev/9ad2f77e6778
> 
> http://hg.mozilla.org/mozilla-central/index.cgi/diff/9ad2f77e6778/configure.in
> may not need to be ported actually.

If we port this, then we can cut down on our additions:

http://mxr.mozilla.org/comm-central/search?string=framework+AddressBook

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 335787 [details] [diff] [review]
patch to port all those changes to comm-central

This looks good and I'm happy for it to go in as-is, but I think we should also do the -framework addition as well.

Comment 7

[Robert Kaiser]

Right, the -framework addition sounds correct, as bug 394901 comment #15 implies that they added -framework AddressBook as a platform requirement.

Comment 8

[Robert Kaiser]

Attachment: patch, v2: full wget, more framework patches

Here's the updated patch, porting bug 451466 all the way for both apps, and doing a few framework changes - but I can't test on Mac unfortunately, I hope I got that right.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 336043 [details] [diff] [review]
patch, v2: full wget, more framework patches

From the two builds I've done on mac, the framework stuff seems ok, just keep an eye on the trees when you land it ;-)

Comment 10

[Robert Kaiser]

landed as http://hg.mozilla.org/comm-central/rev/0b81d75bf2f3

Comment 11

[Philip Chee]

> bug 450194 - Add -Wno-invalid-offsetof to our warnings flags, because we break
> the rules on purpose

I think you missed: http://hg.mozilla.org/mozilla-central/rev/ccf420d6618b
See: Bug 450194 Comment 11 and Bug 450194 Comment 12

Comment 12

[Robert Kaiser]

Attachment: the additional fix Philip mentioned

Port the additional fix mentioned in the last comment by Philip.

Comment 13

[Robert Kaiser]

Pushed the additional patch as http://hg.mozilla.org/comm-central/rev/455bc7d8dbdd

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> landed as http://hg.mozilla.org/comm-central/rev/0b81d75bf2f3

Ftr, this included the port of:
http://hg.mozilla.org/mozilla-central/rev/8bfe86107c17
Neaten up the handling of configure script regeneration in client.mk.

Comment 15

[Serge Gautherie (:sgautherie)]

(In reply to comment #14)
> http://hg.mozilla.org/mozilla-central/rev/8bfe86107c17
> Neaten up the handling of configure script regeneration in client.mk.

which was part of
http://hg.mozilla.org/mozilla-central/rev/661c6de0b8f0
Merge initial patches for bug 97954: autoconf build environment for spidermonkey