452516 - nsLocalFile::GetNativePath() returns path in UTF8 instead of native encoding under OSX

Status: RESOLVED INVALID

(Core :: Networking: File, defect)

Description

[Michal Novotny [:michal]]

It is not possible to get filepath in native encoding under OSX. It seems that filenames with other than UTF8 encoding can exists on OSX filesystem since bug 408138 can be reproduced there. And that bug can't be fixed in OSX unless GetNativePath() returns filepath in native encoding.

Comment 1

[Honza Bambas (:mayhemer)]

I have spend some time on this. The test from bug 408138 is not able to create file \202.txt. It is not valid file name. Then, there is a comment in net_GetURLSpecFromFile that the code is identacal to the code in the UNIX version of the function. It is not true because the UNIX version is using GetPath on the file but OSX version is using GetNativePath. The test didn't find any problem, if it were sufficient... I ported Michal's fix to OSX helper, but it seems it has no effect. The condition 'if (nativePath == ePath)' is always true.

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: Fix for reference

Ported Michal's fix to OSX version.

Comment 3

[Honza Bambas (:mayhemer)]

There is no problem with this on OS X. If someone feels any different, please reopen, this bug has a working patch for the issue.