This is the very last step about timezones. We still have to fix timezones in emails sent to users about their lost password, about their new account or about their login name change (said otherwise: everything in account/email/). Basically, we have to replace time2str() by format_time(). Everything else has already been fixed in bug 399070.
Note to self: also fix relogin.cgi: my $time_string = time2str('%a, %d-%b-%Y %T %Z', time+(6*60*60), 'GMT'); Also grep for 'time2str' in Bugzilla/* to see if something needs to be fixed there.
Created attachment 354573 [details] [diff] [review] patch, v1 Here is the final step about timezones. Forget my previous comment, there is no need to change anything in relogin.cgi as it's about cookies.
Comment on attachment 354573 [details] [diff] [review] patch, v1 You seem to have forgotten to fix template/en/default/account/email/confirm-new.html.tmpl template. If it was on purpose, you should make same expiration_ts param change as you did for other templates for consistency.
FWIW: many email clients do honor SMTP header entries like Expiry-Date: Tue, 13 Jan 2009 01:30:00 +0500 or Reply-By: Tue, 13 Jan 2009 01:30:00 +0500 putting expiration time here may improve usability
Created attachment 355982 [details] [diff] [review] patch, v1.1 Added the missing template + fixed token.cgi accordingly. No other changes.
Attachment #355982 - Flags: review?(wicked) → review+
Comment on attachment 355982 [details] [diff] [review] patch, v1.1 Awesome, now I see nice timestamps (if I was logged in when the email is generated) that I can compare easily with my wall clock.
Checking in token.cgi; /cvsroot/mozilla/webtools/bugzilla/token.cgi,v <-- token.cgi new revision: 1.60; previous revision: 1.59 done Checking in Bugzilla/Token.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Token.pm,v <-- Token.pm new revision: 1.56; previous revision: 1.55 done Checking in template/en/default/account/cancel-token.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/cancel-token.txt.tmpl,v <-- cancel-token.txt.tmpl new revision: 1.16; previous revision: 1.15 done Checking in template/en/default/account/email/change-new.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/email/change-new.txt.tmpl,v <-- change-new.txt.tmpl new revision: 1.13; previous revision: 1.12 done Checking in template/en/default/account/email/change-old.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/email/change-old.txt.tmpl,v <-- change-old.txt.tmpl new revision: 1.14; previous revision: 1.13 done Checking in template/en/default/account/email/confirm-new.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/email/confirm-new.html.tmpl,v <-- confirm-new.html.tmpl new revision: 1.6; previous revision: 1.5 done Checking in template/en/default/account/email/request-new.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/email/request-new.txt.tmpl,v <-- request-new.txt.tmpl new revision: 1.7; previous revision: 1.6 done Checking in template/en/default/account/password/forgotten-password.txt.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/password/forgotten-password.txt.tmpl,v <-- forgotten-password.txt.tmpl new revision: 1.11; previous revision: 1.10 done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.