Closed
Bug 452521
Opened 16 years ago
Closed 16 years ago
crash getting pop3 mail on startup
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Bienvenu, Assigned: Bienvenu)
Details
(Keywords: crash)
Attachments
(1 file)
|
497 bytes,
patch
|
standard8
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
I added a pop3 account to the global inbox and started running into a crash on startup getting new mail, with a freed memory access. This was in debug mode, but I think we want to fix this. I'm surprised this hasn't affected others...
|
Assignee | |
Comment 1•16 years ago
|
||
the problem was that Release was releasing the last ref, which made m_listener freed memory, which made me crash, in debug mode.
Attachment #335809 -
Flags: superreview?(neil)
Attachment #335809 -
Flags: review?(bugzilla)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 335809 [details] [diff] [review] proposed fix I guess something changed recently, though not in that file apparently. However I agree, this is the safe way to do it.
Attachment #335809 -
Flags: review?(bugzilla) → review+
|
||
Comment 3•16 years ago
|
||
Comment on attachment 335809 [details] [diff] [review] proposed fix >+ rv = (m_listener) ? m_listener->OnStopRunningUrl(nsnull, NS_OK) : NS_OK; Nit: don't need ()s around m_listener
Attachment #335809 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Comment 4•16 years ago
|
||
fixed w/o ()'s around m_listener.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•