452530 - Change the url for eBay search plug-in for (de)

Status: VERIFIED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Mic Berman]

please change the url for the eBay search plug in per a request from eBay due to some system upgrades on their side

the new url should be:
http://rover.ebay.com/rover/1/707-37276-17702-4/4?satitle={searchTerms}

this will require a patch

Comment 1

[Mic Berman]

i have tested the url and it seems to work fine

Comment 2

[Kadir Topal [:atopal]]

Is this only for the German version?

Comment 3

[Axel Hecht [:Pike]]

We're makeing similar changes for a few ebay plugins, this bug is only about the German version, though.

Comment 4

[Kadir Topal [:atopal]]

I guess this needs to be changed on all branches and trunk?

Comment 5

[Staś Małolepszy :stas]

(In reply to comment #4)
> I guess this needs to be changed on all branches and trunk?

If I'm not mistaken, this should land on current trunk (hg) with review and on CVS trunk with review and approval. Axel, is this correct?

We also have confirmation from eBay that satitle is the only parameter to be used in the URL.

Something like:
<Param name="satitle" value="{searchTerms}"/>
should do the trick (with all other <params/> removed and URL's template changed).

Thanks!

Comment 6

[Staś Małolepszy :stas]

(In reply to comment #4)
> I guess this needs to be changed on all branches and trunk?

Ok, just to clarify: 

Please attach patches with the change for current trunk (hg) and for Firefox 3.0.3 (cvs trunk). Both patches will need to be reviewed (you can set the requestee to me) and the cvs one will need to get an approval1.9.0.3.

Thanks!

Comment 7

[Kadir Topal [:atopal]]

Attachment: Fix for branch

Hope this is right

Comment 8

[Kadir Topal [:atopal]]

Attachment: Fix for trunk

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 339476 [details] [diff] [review]
Fix for branch

Per comment 5: please remove all other params and put the 'satitle' in a <Param/> (not in the URL's template). Thank you.

Comment 10

[Staś Małolepszy :stas]

Comment on attachment 339478 [details] [diff] [review]
Fix for trunk

Same as above. 

Also, sorry for adding some confusion: one patch is sufficient, no need to attach two of them. My mistake.

Comment 11

[Kadir Topal [:atopal]]

Attachment: corrected patch

Hope it's right this time

Comment 12

[Staś Małolepszy :stas]

Comment on attachment 340718 [details] [diff] [review]
corrected patch

r=me. Please land it oh hg referencing this bug and my review. For CVS, please wait for approval1.9.0.4.

Thanks.

Comment 13

[Kadir Topal [:atopal]]

checked into trunk

Comment 14

[Staś Małolepszy :stas]

We're still waiting for approval1.9.0.4 and resolution in CVS, so I'll reopen the bug for now.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Stas, check-ins for branches are independend from trunk. Fixing this bug on trunk means that we can mark this bug as fixed. But when the branch patch is checked-in we only set the keyword fixed1.9.0.3 to indicate that its fixed on that given branch.

Comment 16

[Staś Małolepszy :stas]

Thanks Henrik, my bad. It was easier for me to track the progress the other way, but you're right, we should do this the right way (and I can track it anyways) :)

Thanks and sorry for confusion.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.1b1pre) Gecko/20081002 Minefield/3.1b1pre

Comment 18

[Axel Hecht [:Pike]]

Comment on attachment 340718 [details] [diff] [review]
corrected patch

a=me for 3.0.4, please land with a check-in comment referencing this bug and my approval as well as stas' review, and use the fixed1.9.0.4 and verified1.9.0.4 keywords to track landing and testing.