452584 - SetSelectionBounds fails to select content of html:input if it contains two text frames

Status: RESOLVED INCOMPLETE

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

nsIAccessibleEditText::deleteText doesn't work when end offset equals text length

for example, deleteText(0, 5) throws an exception if the input value is "hello".

Comment 1

[alexander :surkov (:asurkov)]

it seems the problem only after insertText. Also setTextContents() fails after insertText.

Comment 2

[alexander :surkov (:asurkov)]

actually SetSelectionBounds() fails to select content of html:input if it contains two frames. Eventually several calls of insertText creates two text frames inside html:input. In this case GetPosAndText returns wrong end frame and accessible and therefore HypertextOffsetsToDOMRange creates wrong range so that range->SetEnd(endNode, endOffset) fails.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 4

[Aaron Leventhal]

Did we run tests on this yet, and do we even have tests the try the various ways it's possible to use getTextAtOffset(), getTextBeforeOffset(), getTextAfterOffset().

For example, I think we used to return null for the startFrame on requests that go past the end. Do we still do that? If no I think it will probably break usages some of those methods at or near the end of a paragraph.

Did GetPosAndText() return end frame of null, and that caused the problem?

Comment 5

[Aaron Leventhal]

Comment on attachment 335898 [details] [diff] [review]
patch

Clearing request until questions answered.

Comment 6

[alexander :surkov (:asurkov)]

Actually that's I'm afraid of. Since we haven't any tests for this and I'm not sure I know entirely that code then I'm afraid to break something. We don't return empty end frame or accessible, we initialize them by start frame and start accessible (http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHyperTextAccessible.cpp#515). So I'm not sure how it can be used.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Ping.

I wonder about AccessibleEditableText.idl. Are the ranges really supposed to be from 0 .. length?

I would have thought 0 .. length-1.

Comment 8

[alexander :surkov (:asurkov)]

Perhaps, but the problem is methods do not work after several calls of InsertText

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Maybe get Roc's thoughts?

Comment 10

[alexander :surkov (:asurkov)]

In general we shouldn't care how much text nodes are inside. If we'll fix this for html:input then we could easily get similar things for editable div for example. In general this is all related with text offset support which should be primary I think.

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

AUTO-CLOSED. This bug untouched for over 2000 days. Please reopen if you can confirm the bug and help it progress.