nsIAbCard needs a method of searching all email addresses (well both of them)

RESOLVED FIXED in Thunderbird 3.0a3

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.0a3
Bug Flags:
wanted-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 335880 [details] [diff] [review]
The fix

I'm doing the inline edit card dialog, and as part of that work for processing updates to the address book, I need to be checking if an email address matches the primary or secondary email address in the card.

I can do this via two lots of getProperty and various to lower case and equals in JS, but that isn't ideal, especially when we could just do it on the card itself.

Therefore I'm proposing that we have nsIAbCard::hasEmailAddress, this is potentially a temporary function until we sort out proper multi-valued attributes, but it makes this work easier, and we already have at least one other place we can use it.

Attaching patch with test case.
Attachment #335880 - Flags: superreview?(bienvenu)
Attachment #335880 - Flags: review?(bienvenu)
Flags: wanted-thunderbird3+

Updated

10 years ago
Attachment #335880 - Flags: superreview?(bienvenu)
Attachment #335880 - Flags: superreview+
Attachment #335880 - Flags: review?(bienvenu)
Attachment #335880 - Flags: review+
Checked in, changeset id: 211:8e89694ee82f
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.