452710 - TakeFocus don't work on linkable accessibles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Comment 1

[alexander :surkov (:asurkov)]

I'll file another bug to test/fix TakeSelection method.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 336007 [details] [diff] [review]
patch

+               "No focused stated for element with ID " + aFocusMgr.mName + ".");

Nit: "no focused state" minus the d after "state". Thanks!

Comment 4

[alexander :surkov (:asurkov)]

checked in http://hg.mozilla.org/mozilla-central/rev/daedaaa2059e

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 336007 [details] [diff] [review]
patch

similar with the bug 449717, major issue for screen readers, would be very nice to put this into firefox 3.0

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 336007 [details] [diff] [review]
patch

Firefox 3.0.2 was frozen last week, requesting to land in 1.9.0.3.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 336007 [details] [diff] [review]
patch

We have to bring in the 3.0.4 schedule, bumping out

Comment 8

[Samuel Sidler (old account; do not CC)]

Resolving as FIXED since this landed on mozilla-central (comment 4).

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 336007 [details] [diff] [review]
patch

Approved for 1.9.0.5, a=dveditz for release-drivers

Comment 10

[Marco Zehe (:MarcoZ)]

Checking in accessible/src/base/nsBaseWidgetAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsBaseWidgetAccessible.cpp,v  <--  nsBaseWidgetAccessible.cpp
new revision: 1.72; previous revision: 1.71
done
Checking in accessible/tests/mochitest/Makefile.in;
/cvsroot/mozilla/accessible/tests/mochitest/Makefile.in,v  <--  Makefile.in
new revision: 1.25; previous revision: 1.24
done
RCS file: /cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessible_focus.html,v
done
Checking in accessible/tests/mochitest/test_nsIAccessible_focus.html;
/cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessible_focus.html,v  <--  test_nsIAccessible_focus.html
initial revision: 1.1
done

Comment 11

[Marco Zehe (:MarcoZ)]

Verified fixed on 1.9.0 branch using Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5