Closed Bug 452710 Opened 12 years ago Closed 11 years ago

TakeFocus don't work on linkable accessibles

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: surkov, Assigned: surkov)

References

Details

(Keywords: access, verified1.9.0.5)

Attachments

(1 file)

 
I'll file another bug to test/fix TakeSelection method.
Summary: TakeFocus and TakeSelection don't work on linkable accessibles → TakeFocus don't work on linkable accessibles
Attached patch patchSplinter Review
Attachment #336007 - Flags: review?(marco.zehe)
Comment on attachment 336007 [details] [diff] [review]
patch

+               "No focused stated for element with ID " + aFocusMgr.mName + ".");

Nit: "no focused state" minus the d after "state". Thanks!
Attachment #336007 - Flags: review?(marco.zehe) → review+
Comment on attachment 336007 [details] [diff] [review]
patch

similar with the bug 449717, major issue for screen readers, would be very nice to put this into firefox 3.0
Attachment #336007 - Flags: approval1.9.0.2?
Attachment #336007 - Flags: approval1.9.0.2? → approval1.9.0.3?
Comment on attachment 336007 [details] [diff] [review]
patch

Firefox 3.0.2 was frozen last week, requesting to land in 1.9.0.3.
Blocks: 453839
Comment on attachment 336007 [details] [diff] [review]
patch

We have to bring in the 3.0.4 schedule, bumping out
Attachment #336007 - Flags: approval1.9.0.4? → approval1.9.0.5?
Resolving as FIXED since this landed on mozilla-central (comment 4).
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 336007 [details] [diff] [review]
patch

Approved for 1.9.0.5, a=dveditz for release-drivers
Attachment #336007 - Flags: approval1.9.0.5? → approval1.9.0.5+
Checking in accessible/src/base/nsBaseWidgetAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsBaseWidgetAccessible.cpp,v  <--  nsBaseWidgetAccessible.cpp
new revision: 1.72; previous revision: 1.71
done
Checking in accessible/tests/mochitest/Makefile.in;
/cvsroot/mozilla/accessible/tests/mochitest/Makefile.in,v  <--  Makefile.in
new revision: 1.25; previous revision: 1.24
done
RCS file: /cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessible_focus.html,v
done
Checking in accessible/tests/mochitest/test_nsIAccessible_focus.html;
/cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessible_focus.html,v  <--  test_nsIAccessible_focus.html
initial revision: 1.1
done
Keywords: access, fixed1.9.0.5
Verified fixed on 1.9.0 branch using Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.1b1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.