452805 - file:///*** is displayed instead of actual URL when D&D internet shortcut.

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[pal-moz]

Attachment: screenshot

regression range is 0827-0828 Nightly.
maybe caused by bug 356295

this happens with some internet shortcuts, not with all internet shortcuts.
and sometimes the page is not loaded,

Comment 1

[Neil Deakin]

Not enough information. Please provide proper steps to reproduce.

Comment 2

[pal-moz]

Attachment: screenshot

[STR]
1) create an internet shortcut file
2) D&D it

if no problem "A1" internet shortcut, try with other ("A2","A3","A4"....) internet shortcut.

Comment 3

[(mostly gone) XtC4UaLL [:xtc4uall]]

STR:
1) create a text file with:

[InternetShortcut]
URL=http://mozilla.org/

and safe this as "test.url" to e.g. desktop.

2)
fire up Fx with a blank tab

3)
drag the icon of the newly created shortcut file to the location bar

expected:
http://mozilla.org/ is being loaded

actual:
"file:///*/test.URL" is being displayed.

error console output:
Security Error: Content at about:blank may not load or link to file:///*/test.URL.

regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-08-27+05%3A00%3A00&enddate=2008-08-28+03%3A00%3A00

Comment 4

[Shayne Jewers]

this happens with File > Open File as well.

Comment 5

[pal-moz]

something to do with this ?

https://bugzilla.mozilla.org/show_bug.cgi?id=452771#c5

Comment 6

[IU]

(In reply to comment #5)
> something to do with this ?
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=452771#c5

NOPE. Still b0rk3n

Comment 7

[Neil Deakin]

Attachment: preliminary patch

The issue here is that files dragged from the desktop have the file type and the url type, but the file type has higher precedence.

This patch changes the nsDragAndDrop.js script so that the types are instead checked in the order getSupportedFlavours returns them.

Comment 8

[Neil Deakin]

Attachment: simpler fix

This patch iterates in the order the flavours are returned by getSupportedFlavours, instead of the order the types were added at the start of the drag. This ensures compatibility with existing code.

Comment 9

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080911105329 Minefield/3.1b1pre

fine now. thanks.