452825 - Language selector on home page not switching locale

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Nelson Ko [:nkoth]]

It brings you to the other language page but the locale is not changed. This is wrong (cilias, can you confirm?). On other kb pages the locale is changed which is the correct behaviour.

This problem may affect other "new non-kb themes" that did not have our custom language switching code.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I noticed the same issue today while trying to check another problem. I opened the http://support.mozilla.com/de/kb/ and selected Espanol from the locale dropdown. I expected to get http://support.mozilla.com/es/kb/ but instead I'm redirected to

http://support.mozilla.com/en-US/kb/Firefox+Support+Home+Page?page=Firefox+Support-Startseite

Comment 2

[Nelson Ko [:nkoth]]

in r18190 (trunk) and r18189 (production)

Comment 3

[Nelson Ko [:nkoth]]

Attachment: Is the default charset and innodb correct?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Anyone, who could push this?

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> Anyone, who could push this?

The SUMO developers will need to request a push from IT, as well as showing that all changes have been appropriately QA'd.

Comment 6

[Chris Ilias [:cilias]]

All 0.6.4 bugs are going to be pushed at the same time. Maybe this Tuesday. I'm not sure.
For meeting notes, see <https://wiki.mozilla.org/Support/SUMOdev_Meeting_Notepad>.

Comment 7

[Laura Thomson :laura]

Yes, we have a push scheduled Tuesday.  I'll file a bug for it in the morning.  We generally push a dot release every two weeks.  (Only critical bugs get pushed outside a scheduled release.)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Not seeing this working; am I testing it incorrectly?

When I switch the locale on the http://support-stage.mozilla.org/en-US/kb/ homepage from en-US to es-ES, I land at http://support-stage.mozilla.org/en-US/kb/Asistencia+de+Firefox+-+P%C3%A1gina+principal.

Reopening.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Stephen, it's not pushed live yet. We have to wait until tomorrow. I'll have an eye on it. Resolving again.

Comment 10

[Laura Thomson :laura]

Henrik, note that Stephen was testing on support-stage which is synced to trunk.  Reopening.

Comment 11

[Nelson Ko [:nkoth]]

Created a bunch of symbolic links to point to the file that fixes this (so that all the themes get it)

in r18570/r18571

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Works like a charm on support-stage.mozilla.org. I've also tested locale switching with sub-pages and everything looks like expected. Thanks Nelson.

Marking verified.