Closed Bug 452865 Opened 16 years ago Closed 16 years ago

Remove obsolete linker flags needed when libnss3 was linked with libsoftokn3

Categories

(NSS :: Build, defect)

3.12
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
3.12.2

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(2 files)

Attached patch Proposed patchSplinter Review
Starting in NSS 3.12, libnss3 is no longer linked with libsoftokn3. So we can remove the obsolete linker flags that were required when libnss3 was linked with libsoftokn3. The proposed patch also removes an obsolete -dylib_file flag for libsqlite3.dylib in lib/nss.
Attachment #336111 - Flags: review?(rrelyea)
Attached patch JSS patchSplinter Review
Glen, could you test this patch on the Mac? This -dylib_file linker flag is not needed if JSS is using NSS 3.12.x.
Attachment #336112 - Flags: review?(glen.beasley)
Attachment #336112 - Flags: review?(glen.beasley) → review+
Attachment #336111 - Flags: superreview?(rrelyea)
Attachment #336111 - Flags: review?(rrelyea)
Attachment #336111 - Flags: review+
Comment on attachment 336111 [details] [diff] [review] Proposed patch when I reviewed the JSS patch. I also applied and reviewed this NSS patch then built/tested.
I checked in the JSS patch on the JSS trunk. Checking in config.mk; /cvsroot/mozilla/security/jss/lib/config.mk,v <-- config.mk new revision: 1.25; previous revision: 1.24 done I checked in the NSS patch on the NSS trunk (NSS 3.12.2). Checking in cmd/platlibs.mk; /cvsroot/mozilla/security/nss/cmd/platlibs.mk,v <-- platlibs.mk new revision: 1.57; previous revision: 1.56 done Checking in lib/nss/config.mk; /cvsroot/mozilla/security/nss/lib/nss/config.mk,v <-- config.mk new revision: 1.32; previous revision: 1.31 done Checking in lib/smime/config.mk; /cvsroot/mozilla/security/nss/lib/smime/config.mk,v <-- config.mk new revision: 1.25; previous revision: 1.24 done Checking in lib/ssl/config.mk; /cvsroot/mozilla/security/nss/lib/ssl/config.mk,v <-- config.mk new revision: 1.25; previous revision: 1.24 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
OS: Mac OS X → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 3.12.2
Attachment #336111 - Flags: superreview?(rrelyea) → superreview+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: