Closed
Bug 452996
Opened 16 years ago
Closed 16 years ago
Thai language pack identifies itself as "English"
Categories
(Mozilla Localizations :: th / Thai, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KaiE, Unassigned)
References
()
Details
(Keywords: fixed1.9.0.4)
Attachments
(2 files, 1 obsolete file)
404 bytes,
patch
|
Pike
:
review-
|
Details | Diff | Splinter Review |
382 bytes,
patch
|
markpeak
:
review+
Pike
:
approval1.9.0.4+
|
Details | Diff | Splinter Review |
Use Firefox 3.0.x Install ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.9.0-l10n/linux-xpi/th.xpi Restart Firefox Go to Add-Ons/Languages The list of installed language packs does not list anything with "Thai". Instead, I see a "English (US) Language Pack" with version 3.0.3pre. I'm pretty sure that's the one installed, as all my other packs have version 3.0.1 Expected behavior: The language pack should (probably) identify itself as "Thai (TH) Language Pack".
Flags: wanted1.9.0.x?
Reporter | ||
Comment 1•16 years ago
|
||
Wild guess, the following file might be the cause: http://mxr.mozilla.org/l10n/source/th/toolkit/defines.inc it currenly says: #define MOZ_LANG_TITLE English (US)
Reporter | ||
Comment 2•16 years ago
|
||
Note I don't have commit access for l10n
Attachment #336224 -
Flags: review?(l10n)
Comment 3•16 years ago
|
||
Or it should be #define MOZ_LANG_TITLE ภาษาไทย (TH) ?
Comment 4•16 years ago
|
||
Languages make this 50-50, in the case of Thai, I'd actually prefer "Thai", without anything in braces. As we're just using Thai as language name, and not "Thai (Thailand)".
Comment 5•16 years ago
|
||
Comment on attachment 336224 [details] [diff] [review] Patch v1 Moving review request over to localization owner.
Attachment #336224 -
Flags: review?(l10n) → review?(markpeak)
Comment 6•16 years ago
|
||
I agree with Axel's suggestion. Thai is OK. Anyway, I think I don't have permission for approve the review.
Comment 7•16 years ago
|
||
Comment on attachment 336224 [details] [diff] [review] Patch v1 r- based on Isriya's comment. Isriya, can you attach a new patch for approval to land in CVS? You're now among the shipping localizations, so that's required.
Attachment #336224 -
Flags: review?(markpeak) → review-
Reporter | ||
Comment 8•16 years ago
|
||
Updated patch that uses Patipat's proposed text from comment 3
Attachment #336224 -
Attachment is obsolete: true
Attachment #336347 -
Flags: review?(l10n)
Updated•16 years ago
|
Attachment #336347 -
Flags: review?(l10n) → review-
Comment 9•16 years ago
|
||
Comment on attachment 336347 [details] [diff] [review] Patch v2 Duh, the owner said the opposite. I'm not the right reviewer here, btw.
Reporter | ||
Comment 10•16 years ago
|
||
Hmm, I read your comments again. I think you said you want this.
Attachment #336349 -
Flags: review?(l10n)
Updated•16 years ago
|
Attachment #336349 -
Flags: review?(l10n)
Comment 11•16 years ago
|
||
Comment on attachment 336349 [details] [diff] [review] Patch v3 I don't want to review this in the first place.
Reporter | ||
Updated•16 years ago
|
Attachment #336349 -
Flags: review?(markpeak)
Updated•16 years ago
|
Attachment #336349 -
Flags: review?(markpeak) → review+
Reporter | ||
Updated•16 years ago
|
Attachment #336349 -
Flags: approval1.9.0.2?
Reporter | ||
Comment 12•16 years ago
|
||
Comment on attachment 336349 [details] [diff] [review] Patch v3 requesting approval for 1.9.0.2 if this is too late, please bump the approval request to 1.9.0.3 thanks
Comment 13•16 years ago
|
||
landed on CVS. r=markpeak@gmail.com Axel, is it to late to push to 1.9.0.2?
Updated•16 years ago
|
Attachment #336349 -
Flags: approval1.9.0.2? → approval1.9.0.3+
Comment 14•16 years ago
|
||
Comment on attachment 336349 [details] [diff] [review] Patch v3 post-facto approval for firefox 3.0.3. Please use the fixed1.9.0.3 and verified1.9.0.3 keywords to track landing and testing. I.e., now the bug should get the keyword fixed1.9.0.3, and once you have tested the fix on a language pack from ftp, the fixed1.9.0.3 keyword should be replaced with a verified1.9.0.3 keyword.
Updated•16 years ago
|
Flags: wanted1.9.0.x?
Comment 15•16 years ago
|
||
Axel, I got "Permission denied" error from the CVS. It seems that my key change request in bug #450148 has something missing. I already tested this key pair with my own server and it works fine. I asked Patipat to land it for me.
Updated•16 years ago
|
Keywords: fixed1.9.0.3
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 16•16 years ago
|
||
Isriya, please follow up in bug 450148 with details on the error, in particular a cvs -t status th/browser/defines.inc should be a good first step.
You need to log in
before you can comment on or make changes to this bug.
Description
•