453062 - Drag'n'dropping an image to Desktop results in a .webloc file

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Andrea Guglielmi]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080830020452 Minefield/3.1b1pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080830020452 Minefield/3.1b1pre

I was wondering why I wasn't able to drag and drop images to iTunes so I tried to drop it on Desktop and I saw FF created a XML file.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.mozilla.com/en-US/firefox/
2. Drag the "Firefox 3 Free Download..." image to the desktop
Actual Results:  
A "Free Download 3.0.1 for Mac OS X 10.4 and above English (US) (17.4MB)" file is created. The file content is:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
        <key>URL</key>
        <string>http://www.mozilla.com/products/download.html?product=firefox-3.0.1&amp;os=osx&amp;lang=en-US</string>
</dict>
</plist>

Expected Results:  
A copy of the image on the desktop

If you drag an <A>nchor image the resulting name is the <A> itself. If you drag a simple image the resulting name is something like:
http-::www.aiutamici.com:ftp:images:software:mp3directcut10.png.webloc

Comment 1

[philippe (part-time)]

clarifying the summary: dragging creates a link (.webloc) to the image on the server instead of dropping the image on the desktop.

fails
Gecko/20080828020913 Minefield/3.1a2pre

works
Gecko/20080827044342 Minefield/3.1a2pre

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-08-27+02%3A09%3A13&enddate=2008-08-28+04%3A43%3A42

--> bug 356295 almost certainly

Comment 2

[Neil Deakin]

Attachment: fix dragging images to desktop

Seems that draggings nsISupports need to be wrapped in an nsISupportsInterfacePointer.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 336363 [details] [diff] [review]
fix dragging images to desktop

(Just a link for myself:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/base/src/nsCopySupport.cpp&rev=1.56&mark=438-449#404)

>+    else {
>+      // wrap the item in an nsISupportsInterfacePointer
>+      nsCOMPtr<nsISupportsInterfacePointer> ptrSupports =
>+        do_CreateInstance(NS_SUPPORTS_INTERFACE_POINTER_CONTRACTID);
>+      if (!ptrSupports)
>+        return PR_FALSE;
> 
>-    // for flavour data providers, use kFlavorHasDataProvider (which has the
>-    // value 0) as the length.
>-    nsCOMPtr<nsIFlavorDataProvider> fdp = do_QueryInterface(*aSupports);
>-    *aLength = fdp ? sizeof(nsISupports) : nsITransferable::kFlavorHasDataProvider;
>+      ptrSupports->SetData(data);
>+      NS_ADDREF(*aSupports = ptrSupports);
Couldn't you do ptrSupports.swap(aSupports);