453105 - Error: setting a property that has only a getter on cars.com

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

I think this might be fallout from bug 407216, because I just started seeing this after updating to today's nightly.

Steps to Reproduce:

1. Load http://www.cars.com/go/index.jsp
2. Attempt to use the pulldown menus to select eithed Used or New cars

Actual Results:

Error: setting a property that has only a getter
Source File: http://www.cars.com/includes/js/search.js
Line: 57

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Works in: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b1pre) Gecko/20080830020452 Minefield/3.1b1pre

Broken in: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080831162801 Minefield/3.1b1pre

Comment 2

[Bill Gianopoulos [:WG9s]]

Confirmed under Windows and Linux.

Platform/OS -> ALL

Comment 3

[Jason Orendorff [:jorendorff]]

Taking.  Clearly a regression from bug 407216.  Fix coming shortly.

Comment 4

[Jason Orendorff [:jorendorff]]

Hmm, it wasn't quite what I thought it was.  nsHTMLOptionsCollection is an
example of a class that implements multiple interfaces which each have
definitions of some members, in this case nsIDOMHTMLOptionsCollection.length
(which is not readonly) and nsIDOMHTMLCollection.length (which is).

Quick stubs have problems with these.

Another example smaug pointed out on IRC was nsIDOMEventTarget.addEventListener
(which has 3 parameters) and nsIDOMNSEventTarget (which has 4); there's a
special case in nsDOMClassInfo to cope with this one.  I should just delete
addEventListener from dom_quickstubs.qsconf.  But I'd hate to lose length.

Fix will have to wait for tomorrow.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Please make sure to add a test when you fix this.

Comment 6

[Bill Gianopoulos [:WG9s]]

Well, for a workaround, commenting out:

    'nsIDOMHTMLCollection.length',

in dom_quickstubs.qsconf avoids the issue.l

Comment 7

[Jason Orendorff [:jorendorff]]

Attachment: v1

The fix described in comment 6.  Filed 453331 about the more general case.

Comment 8

[Jason Orendorff [:jorendorff]]

Attachment: tests v1

While I'm waiting for the tree to reopen, here are some tests.

(Note: these could be xpcshell-based tests, but bz and I saw some value in testing it in the browser and checking that the control actually gets redrawn.  What the heck.)

I didn't see any naming conventions for reftest files.

Comment 9

[Tony Mechelynck [:tonymec]]

(In reply to comment #1)
> Works in: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b1pre)
> Gecko/20080830020452 Minefield/3.1b1pre
> 
> Broken in: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre)
> Gecko/20080831162801 Minefield/3.1b1pre

(In reply to comment #2)
> Confirmed under Windows and Linux.
> 
> Platform/OS -> ALL

Also SeaMonkey (trunk):
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20080902011844 SeaMonkey/2.0a1pre

I'll be keeping an eye on this bug too.

Comment 10

[Tony Mechelynck [:tonymec]]

P.S. In case that car dealer's page should change, there is another tescase at https://bugzilla.mozilla.org/chart.cgi where (with the bug) the second and third selection boxes appear empty.

Comment 11

[Tom Kloos]

The same bug appears to have broken http://ati.amd.com/support/driver.html too.  The selection list isn't filled in.  Works fine on "Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080831003516 SeaMonkey/2.0a1pre" but fails on the 20080901002016 build.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 336583 [details] [diff] [review]
tests v1

Looks good.

Comment 13

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/mozilla-central/rev/2abc3b6b4b17

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.1b1pre) Gecko/20080904020533 Minefield/3.1b1pre

Comment 16

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090312 Shiretoko/3.1b4pre. Adding keyword.