Closed Bug 453106 Opened 11 years ago Closed 11 years ago

[eo] Search engine setup for Firefox 3 for Esperanto.

Categories

(Mozilla Localizations :: eo / Esperanto, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

Details

(Keywords: fixed1.9.0.4, verified1.9.0.4)

Attachments

(3 files, 4 obsolete files)

This is a spin-off from bug 402032.

We want to ship Firefox 3 a good list of search engines for Esperanto.

We're going to work towards this in three phases. First, the localization team and Stas (Staś Małolepszy) will look at the market for the language and come up with a good set of search providers. Eduardo, we'll need your input on this, the guidelines for making recommendations are on http://wiki.mozilla.org/Firefox_web_services_guidelines. 

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:
Google, Yahoo, Amazon, Answers, CC, eBay, Wikipedia

After we decided on a particular search engine, Stas and Mic will contact the owner and ask for permission, and for specifics like proper search flags. undefined, we'll likely need your help to at least get the contact information.

Once we have a specification on what the searchengines for Esperanto should look like, the localization team and Axel will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas or Axel. After a successful review, the localization team will land them.

Please don't commit any modifications in l10n/eo/browser/searchplugins to the cvs repository without a patch reviewed by Stas or Axel, or someone else appointed by Seth. The data here is sensitive to users and our search partners, thus the extra care here.

Reading across bug 402032, it seems like the only change for search so far is changing en.wikipedia.org to eo.wikipedia.org. Eduardo, is that right?
Yes, that would be the only change so far.
Eduardo, are there any dictionaries or maybe texts (books, articles) databases that might be useful to have search plug-ins for in the Esperanto build?
Staś, yes there are, the most used are the ones Aleksej mentioned.  I uploaded the xml files, they ready to be put in the searchplugins directory.
Attached patch Search plugins (obsolete) — Splinter Review
Diff against current CVS.
Attachment #337130 - Attachment is obsolete: true
Attachment #337132 - Attachment is obsolete: true
Eduardo, great to see the patch, but let me come in with a couple of questions/issues:

1. You only added Reta Vortaro in the end, what about Komputeko? (I think it looked like a good idea to include it as well)

2. What about Wikipedia? :) It's not in the patch either.

3. We probably need to make some choices and limit the final list of search plugins to 6-7. I would suggest the following list:

* google
* yahoo
* amazon
* ebay
* eo.wikipedia
* reta vortaro
* komuteko

(left out: answers and CC). What do you think? Do you have other suggestions?
Re: Komputeko plug-in - I'd suggest putting {seachTerms} in a separate <Param/> element, just like you did for Reta Vortaro.
Attached patch Search plugins (obsolete) — Splinter Review
Thanks Staś for your comments.  I had forgotten wikipedia.  Reta-vortaro is the best choice for an online dictionary (komputeko is technical).  We kept CC and removed answers.  So, the list has seven plugins.
Attachment #337491 - Attachment is obsolete: true
Attachment #338147 - Flags: review?(stas)
So the final list is:

* google
* yahoo
* amazon
* CC
* ebay
* reta vortaro
* wikipedia (eo)

Thanks.
Comment on attachment 338147 [details] [diff] [review]
Search plugins

>Index: eo/browser/searchplugins/list.txt
>-wikipedia
>+vikipedio-eo

Please rename vikipedio-eo to wikipedia-eo. 


>Index: eo/browser/searchplugins/reta-vortaro.xml
>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/" xmlns:os="http://a9.com/-/spec/opensearch/1.1/">

You can use only MozSearch's namespace (http://www.mozilla.org/2006/browser/search/) and this way drop all os: prefixes. The above XML valid, but keeping everything in the MozSearch format is preferred.


>Index: eo/browser/searchplugins/vikipedio-eo.xml
>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/" xmlns:os="http://a9.com/-/spec/opensearch/1.1/">

Same as above.


>+<os:Url type="text/html" method="GET" template="http://eo.wikipedia.org/w/index.php?title=Speciala:Search&amp;search={searchTerms}">
>+</os:Url><os:Url type="application/x-suggestions+json" method="GET" template="http://eo.wikipedia.org/w/api.php?action=opensearch&amp;search={searchTerms}&amp;namespace=0">
>+</os:Url><os:Url type="application/x-suggestions+xml" method="GET" template="http://eo.wikipedia.org/w/api.php?action=opensearch&amp;format=xml&amp;search={searchTerms}&amp;namespace=0">
>+</os:Url>

I would recommend using <Param/> for GET parameters in the URLs. It makes things easy to read and maintain. Please use two-spaces indentation before every <Param/>. So this:

<os:Url type="text/html" method="GET" template="http://eo.wikipedia.org/w/index.php?title=Speciala:Search&amp;search={searchTerms}"></os:Url>

would become this:

<Url type="text/html" method="GET" template="http://eo.wikipedia.org/wiki/Speciala:Search">
  <Param name="search" value="{searchTerms}"/>
  <Param name="sourceid" value="Mozilla-search"/>
</Url>

(note the changed template and new parameter - sourceid).

Hope this helps. Thanks!
Attachment #338147 - Flags: review?(stas) → review-
Attached patch Search pluginsSplinter Review
Renamed vikipedio-eo.xml to wikipedia-eo.xml (also modified in list.txt)
Erased the a9.com namespace and removed all os: prefixes (in wikipedia-eo and reta-vortaro)
About the parameters, for this version I used the en-US wikipedia.xml as the model.

Both search engines were tested. Thanks for the explanations, I hope it's ok now.
Attachment #338147 - Attachment is obsolete: true
Attachment #339462 - Flags: review?(stas)
Attachment #339462 - Flags: review?(stas) → review+
Comment on attachment 339462 [details] [diff] [review]
Search plugins

r=me.

A tiny nit:

>+<Url type="text/html" method="GET" template="http://eo.wikipedia.org/wiki/Special:Search">

It works just fine, but I noticed that last time you used "Speciala:Search" instead of "Special:Search". It doesn't seem to make a difference except for having an English word in the URL :)
Eduardo, can you help me find a contact to people behind Reta Vortaro?
Sure Staś.  I've already sent their addresses to you.
Patch landed (with the fixed URL :) ).
Got the permission from Wieland Pusch:

======================================

Hello Stanislaw,

I am happy, that you include ReVo as default search.
This mail is a permission to do that.
Traffic is (almost) no problem, but you never know.
Your idea to add a parameter to identify the traffic is very good.
Please include something like
<Param name="mozilla" value="1"/>
<Param name="from" value="mozilla"/>
Or something else with mozilla or firefox.

======================================

Eduardo, we'll need to add another parameter to the plugin, I'll make the patch in a second.
Hmm, I'm having some weird problems with the revo site right now. Eduardo, can you confirm this, please?
Eduardo, do you want to land the patch on hg, or maybe I can do it?
The problem seems to be gone.

About the patch, I can land it.  Could you attach it?  By the way, just to hg or also to CVS?
Sure, but it looks like you didn't push the attachment 339462 [details] [diff] [review] (previous patch) on hg. Mind doing that?
Sorry, I had done it only on cvs.  It's done now.
(In reply to comment #23)
> Sorry, I had done it only on cvs.  It's done now.

Hmm, I think you forgot to do 'hg add' on the new search plugins. :)
Indeed :)  add/push.  It seems to have been landed.
Please test it and if it's OK, commit it to cvs and hg. Thanks!
Attachment #340330 - Flags: review?(eduardo)
It's ok.  Commited to cvs and hg.  I could not set the review flag (lack of permission).
Attachment #340330 - Flags: review?(eduardo) → review+
Attachment #339462 - Flags: approval1.9.0.4?
Comment on attachment 339462 [details] [diff] [review]
Search plugins

Asking Pike for a post facto approval1.9.0.4. Eduardo, normally we should do this the other way round (first approval, than landing on cvs) :)
Comment on attachment 340330 [details] [diff] [review]
Add from=mozilla to reta vortaro plugin

ditto
Attachment #340330 - Flags: approval1.9.0.4?
Attachment #339462 - Flags: approval1.9.0.4? → approval1.9.0.4+
Comment on attachment 339462 [details] [diff] [review]
Search plugins

post-mortem approval for this. Please use the fixed1.9.0.4 and verified1.9.0.4 keywords to track landing and testing.
Attachment #340330 - Flags: approval1.9.0.4? → approval1.9.0.4+
Ok.  But how do I know when a change needs approval, review or when it can be
landed right away?  The bugs states "Please don't commit any modifications in
l10n/eo/browser/searchplugins to the cvs repository without a patch reviewed by
Stas or Axel, or someone else appointed by Seth."

That made me think that your review was enough ...

And then you asked me in #22 to do the push.  Maybe it was ok to commit to hg
but not to cvs?  Can I read about this somewhere so I can do it right?
Eduardo is right. Approval is only required for locales that are actually part of Firefox shippings, i.e., in Beta or beyond.

When that happens, I or Seth or Stas will add a comment to your shipping bug with the new tree rules, for example like bug 415575 comment 5.
Eduardo, Axel, sorry, I got confused. Thanks for pointing this out to me.

Eduardo, thanks for preparing and landing the patches. I think we can close this bug now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.