pushlog turns line breaks in commit messages into spaces

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: jruderman, Assigned: gps)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/842] , URL)

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
http://hg.mozilla.org/tracemonkey/pushloghtml?startdate=2008-09-01+00%3A00%3A00&enddate=2008-09-01+03%3A00%3A00 is hard to read because the line breaks were not preserved.  They should have been turned into <br>s, I guess.
It should use the |firstline filter as is used in changelog and shortlog.
(Reporter)

Comment 2

11 years ago
Why only show the first line?
This is what hg does nearly everywhere: show the first line of the commit message in the overview, then a user can expand it to show the full message.
(Reporter)

Comment 4

11 years ago
Ah, I didn't know I could click the commit to read the entire message.  It would be a lot less confusing if the overview included a clickable "..." on cut-off commit messages.
I'd prefer to just turn them into <br>s and show the entire thing. We typically don't get huge commit messages.
Actually, I like Jesse's idea. We could show only the first line of multi-line commit messages, with a clickable ellipsis that shows the rest (using JS).

Sid: this sounds like itd be a pretty easy patch. Interested? :)
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 7

10 years ago
ted, sounds good. I'll take it up. Just to make sure though, you want the ellipsis link pointing to the appropriate changeset link? So in the above case it would be:

http://hg.mozilla.org/tracemonkey/rev/310ff794218c
No, I'd like to have the ellipsis link just have an onclick that expands the commit message from the first line to show the entire message.
Assignee: nobody → sid

Comment 9

10 years ago
Created attachment 372296 [details] [diff] [review]
Patch for hg_templates to add expand/collapse functionality for commit messages with line breaks

Please see the following link for more details:

http://blog.sidkalra.com/2009/04/v09-release-fix-for-the-line-break-bug/
Attachment #372296 - Flags: review?(ted.mielczarek)
Ted, looking at your review queue, these patches go back a while.  Do you have review comments that haven't been addressed in order for you to r+?  If not, are you planning to review?  And, if you don't think we should take these, can you r-?  

If there are comments that have yet to be addressed, does it make sense to clear these requests and ask for another request after the comments have been addressed?
I think most of these patches are probably ok, I just didn't find time to review them. I haven't context switched to look at pushlog stuff in a long time, so they fell to the back burner. Plus, Sid (while he did great work), finished his course and moved on and stopped bugging me for reviews.

Comment 12

9 years ago
Ted? Let's try to finish this one.
Comment on attachment 372296 [details] [diff] [review]
Patch for hg_templates to add expand/collapse functionality for commit messages with line breaks

Clearing old review requests. We can revisit these at a later date.
Attachment #372296 - Flags: review?(ted.mielczarek)
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/297]

Updated

4 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/297] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/842] [kanban:engops:https://kanbanize.com/ctrl_board/6/297]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/842] [kanban:engops:https://kanbanize.com/ctrl_board/6/297] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/842]
(Assignee)

Comment 14

4 years ago
Created attachment 8543088 [details] [diff] [review]
pushlog: render line breaks with <br /> ()

Multi-line commit messages in pushloghtml were having their newlines
rendered as spaces. Converting them to <br /> via the "addbreaks" filter
makes commit message formatting on pushloghtml much more pleasant to
read.

Personally, I like the idea of an ellipsis. But I'm lazy and don't feel
like implementing that. We can always do it later.
Attachment #8543088 - Flags: review?(bkero)
(Assignee)

Updated

4 years ago
Assignee: sid → gps
Status: NEW → ASSIGNED
The clickable ellipsis would be best but this is terrible right now and putting linebreaks in is better than what we currently have.

Updated

4 years ago
Attachment #8543088 - Flags: review?(bkero) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 17

4 years ago
This has been deployed.
You need to log in before you can comment on or make changes to this bug.