453231 - Fennec fails to complete Dromaeo DOM tests (OOM)

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Fall out from bug 445923.

We currently run out of memory when running the Dromaeo tests.

Comment 1

[gyuyoung kim]

In my opinion, we should decide how much memory SpiderMonkey can use on mobile device, for example, 5 MB, 6 MB and so on. In order words, we need to make a threshold for SpiderMonkey.

Internally, SpiderMonkey has two counters (gcMallocBytes, gcBytes) in order to monitor the memory allocated by JS_malloc() and allocated by NewGCArena(). It seems to me we can implement the dialog using those counter variables.

Comment 2

[gyuyoung kim]

I tried to implement my idea which was mentioned in Bug 445923 Comment #4.
I can control a peak memory and reduce a bit memory consumption. But, page loading time is more slower because GC is called more frequently. This is a trade-off between memory and speed. If we can reduce the GC cost, I think this idea can be helpful to fennec. And it seems this idea can be combined with this bug.

Test scenario is 
  1. Run firefox on N810
  2. Access google home (http://www.google.com/en)
  3. Search for "spidermonkey" keyword.
  4. Open 7 tabs in the searching result.
  5. Close firefox.

And, below numbers show only a memory size allocated by NewGCArena().
Below result doesn't include a memory size consumed by JS_malloc(). I don't know how can I control a memory consumed by JS_malloc() yet.

Test Result is as below,

 - Normal Firefox
   * Total # of GC call : 53 times
   * Total used memory : 6.9 MB
   * Peak size of memory : 3.5 MB
  
 - Firefox with this idea
   * Total # of GC call : 62 times
   * Total used memory : 5.2 MB
   * Peak size of memory : 2.0 MB

Comment 3

[Stuart Parmenter]

thanks for looking in to this.  we should talk to the JS guys and see if we can GC a bit more frequently

Comment 4

[gyuyoung kim]

In bug 454728, it seems Dougt already implemented a patch for JavaScript's OOM. So, a low memory popup comes out when Dromaeo test is run.

But, current Dromaeo can not be done on N810 because Dromaeo needs a lot of memory in order to finish the test. It is difficult to finish Dromaeo test because of frequent low memory popup.

If I find any solutions which can finish Dromaeo test, I will post it.

Comment 5

[Doug Turner (:dougt)]

brad, do you see this with your jemalloc patch?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

This works fine for me on N900 and N1