Closed Bug 453254 Opened 16 years ago Closed 16 years ago

nsZipReaderCache::GetZip doesn't null-check the zipFile argument

Categories

(Core :: Networking: JAR, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: WeirdAl, Assigned: WeirdAl)

References

()

Details

(Keywords: crash, fixed1.8.1.18, verified1.9.0.4)

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attached patch patch (obsolete) — Splinter Review
I'm compiling with this patch now, I'll let you know test results as soon as I can.
Assignee: nobody → ajvincent
Status: NEW → ASSIGNED
Attachment #336446 - Flags: superreview?(cbiesinger)
Attachment #336446 - Flags: review?(cbiesinger)
xpcshell test passes, this fixes the crash.
Comment on attachment 336446 [details] [diff] [review]
patch

+  NS_ENSURE_ARG(zipFile);

should be NS_ENSURE_ARG_POINTER (and an appropriately fixed test)
Attachment #336446 - Flags: superreview?(cbiesinger)
Attachment #336446 - Flags: superreview+
Attachment #336446 - Flags: review?(cbiesinger)
Attachment #336446 - Flags: review+
Attachment #336446 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/6c8c8fc37617
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
Null dereference crash, simple fix, requesting approval for 1.9.0.x and 1.8.1.x branches.
Flags: wanted1.9.0.x?
Flags: wanted1.8.1.x?
whoops, wrong way to do it
Flags: wanted1.9.0.x?
Flags: wanted1.8.1.x?
Comment on attachment 336446 [details] [diff] [review]
patch

Null dereference crash, simple fix, requesting approval for 1.9.0.x and 1.8.1.x
branches.
Attachment #336446 - Flags: approval1.9.0.3?
Attachment #336446 - Flags: approval1.8.1.18?
Attachment #336446 - Flags: approval1.9.0.3?
Attachment #336446 - Flags: approval1.8.1.18?
Comment on attachment 336448 [details] [diff] [review]
patch corrected for check-in

Approved for 1.8.1.17 and 1.9.0.3, a=dveditz for release-drivers
Attachment #336448 - Flags: approval1.9.0.3+
Attachment #336448 - Flags: approval1.8.1.18+
Alex: Are you intending on getting this checked in?
Samuel, I don't have checkin privileges, someone else will have to do it for me.
Keywords: checkin-needed
Whiteboard: needs checkin on the 1.8 and 1.9.0 branches
Fix checked into 1.8 and 1.9.0 branches
Is there a test case or repro steps to verify this bug?
Al:  The patch includes a xpcshell testcase, so trunk and 1.9 tinderboxes will already be running it. (I hope!)
In fact, I see it running and passing at http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.0/1224785686.1224788396.19521.gz.

Marking it as verified for 1.9.0.4.
Of course, I should verify it for 1.8.1.18 as well but the test doesn't run there.
Flags: in-testsuite+
Whiteboard: needs checkin on the 1.8 and 1.9.0 branches
You need to log in before you can comment on or make changes to this bug.