453254 - nsZipReaderCache::GetZip doesn't null-check the zipFile argument

Status: RESOLVED FIXED

(Core :: Networking: JAR, defect)

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: patch

I'm compiling with this patch now, I'll let you know test results as soon as I can.

Comment 2

[Alex Vincent [:WeirdAl]]

xpcshell test passes, this fixes the crash.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 336446 [details] [diff] [review]
patch

+  NS_ENSURE_ARG(zipFile);

should be NS_ENSURE_ARG_POINTER (and an appropriately fixed test)

Comment 4

[Alex Vincent [:WeirdAl]]

Attachment: patch corrected for check-in

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/6c8c8fc37617

Comment 6

[Alex Vincent [:WeirdAl]]

Null dereference crash, simple fix, requesting approval for 1.9.0.x and 1.8.1.x branches.

Comment 7

[Alex Vincent [:WeirdAl]]

whoops, wrong way to do it

Comment 8

[Alex Vincent [:WeirdAl]]

Comment on attachment 336446 [details] [diff] [review]
patch

Null dereference crash, simple fix, requesting approval for 1.9.0.x and 1.8.1.x
branches.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 336448 [details] [diff] [review]
patch corrected for check-in

Approved for 1.8.1.17 and 1.9.0.3, a=dveditz for release-drivers

Comment 10

[Samuel Sidler (old account; do not CC)]

Alex: Are you intending on getting this checked in?

Comment 11

[Alex Vincent [:WeirdAl]]

Samuel, I don't have checkin privileges, someone else will have to do it for me.

Comment 12

[Daniel Veditz [:dveditz]]

Fix checked into 1.8 and 1.9.0 branches

Comment 13

[Al Billings [:abillings - ex-MoCo]]

Is there a test case or repro steps to verify this bug?

Comment 14

[Alex Vincent [:WeirdAl]]

Al:  The patch includes a xpcshell testcase, so trunk and 1.9 tinderboxes will already be running it. (I hope!)

Comment 15

[Al Billings [:abillings - ex-MoCo]]

In fact, I see it running and passing at http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.0/1224785686.1224788396.19521.gz.

Marking it as verified for 1.9.0.4.

Comment 16

[Al Billings [:abillings - ex-MoCo]]

Of course, I should verify it for 1.8.1.18 as well but the test doesn't run there.