Closed
Bug 453341
Opened 16 years ago
Closed 16 years ago
Allow stack checking to be suppressed per-function
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
1.50 KB,
patch
|
dmandelin
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
In XPCWrappedNative::CallMethod there's a call to "new nsAutoString" which should be allowed as a special exception. I can't see how to annotate that particular call, so I've implemented a solution that suppressed stack checking for that entire method.
Attachment #336521 -
Flags: superreview?(jst)
Attachment #336521 -
Flags: review?(dmandelin)
Updated•16 years ago
|
Attachment #336521 -
Flags: superreview?(jst) → superreview+
Updated•16 years ago
|
Attachment #336521 -
Flags: review?(dmandelin) → review+
Comment 1•16 years ago
|
||
Comment on attachment 336521 [details] [diff] [review]
Supress stack checking for XPCWrappedNative::CallMethod, rev. 1
Not sure what you wanted to me to look at. This looks fine. If you want to see if there is some way to avoid the annotation, well that would be a lot harder to tell. :-)
Assignee | ||
Comment 2•16 years ago
|
||
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/63f2ff5b4cee
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•