Allow stack checking to be suppressed per-function

RESOLVED FIXED in mozilla1.9.1b1

Status

RESOLVED FIXED
10 years ago
9 months ago

People

(Reporter: benjamin, Assigned: benjamin)

Tracking

Trunk
mozilla1.9.1b1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 336521 [details] [diff] [review]
Supress stack checking for XPCWrappedNative::CallMethod, rev. 1

In XPCWrappedNative::CallMethod there's a call to "new nsAutoString" which should be allowed as a special exception. I can't see how to annotate that particular call, so I've implemented a solution that suppressed stack checking for that entire method.
Attachment #336521 - Flags: superreview?(jst)
Attachment #336521 - Flags: review?(dmandelin)

Updated

10 years ago
Attachment #336521 - Flags: superreview?(jst) → superreview+
Attachment #336521 - Flags: review?(dmandelin) → review+
Comment on attachment 336521 [details] [diff] [review]
Supress stack checking for XPCWrappedNative::CallMethod, rev. 1

Not sure what you wanted to me to look at. This looks fine. If you want to see if there is some way to avoid the annotation, well that would be a lot harder to tell. :-)
(Assignee)

Comment 2

10 years ago
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/63f2ff5b4cee
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Blocks: 78388
Target Milestone: --- → mozilla1.9.1b1
Version: unspecified → Trunk

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.