Closed Bug 453341 Opened 16 years ago Closed 16 years ago

Allow stack checking to be suppressed per-function

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file)

In XPCWrappedNative::CallMethod there's a call to "new nsAutoString" which should be allowed as a special exception. I can't see how to annotate that particular call, so I've implemented a solution that suppressed stack checking for that entire method.
Attachment #336521 - Flags: superreview?(jst)
Attachment #336521 - Flags: review?(dmandelin)
Attachment #336521 - Flags: superreview?(jst) → superreview+
Attachment #336521 - Flags: review?(dmandelin) → review+
Comment on attachment 336521 [details] [diff] [review]
Supress stack checking for XPCWrappedNative::CallMethod, rev. 1

Not sure what you wanted to me to look at. This looks fine. If you want to see if there is some way to avoid the annotation, well that would be a lot harder to tell. :-)
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/63f2ff5b4cee
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Blocks: 78388
Target Milestone: --- → mozilla1.9.1b1
Version: unspecified → Trunk
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: