Created attachment 336590 [details] [diff] [review] NS_HILDON -> MOZ_WIDGET_GTK_MAEMO MOZ_WIDGET_GTK_MAEMO is more descriptive and express better specific changes in mozilla' gtk2 toolkit support for maemo.
Created attachment 336593 [details] [diff] [review] GTK -> GTK2
i do not understand why the change. does libhildonmime imply MOZ_WIDGET_GTK_MAEMO now? What about osso stuff?
Created attachment 336603 [details] [diff] [review] v2 better pkg-config check (?) doug, for NS_OSSO to NS_MAEMO I will file another bug.
After a fair amount of discussion on irc, I'm going to mark this as invalid. Hildon is more than just widget and more than just maemo, so changing the macro to MOZ_WIDGET_GTK2_MAEMO wouldn't quite be right. It seems the other alternative would be to create a separate macro for everything that hildon is (MOZ_WIDGET_GTK2_HILDON, MOZ_WIDGET_QT_HILDON, MOZ_MIME_HILDON, etc...), but this seems like a mess IMHO.
How about MOZ_PLATFORM_HILDON? NS_HILDON, NS_MAEMO and NS_OSSO are all completely meaningless to most people reading the code.
that works for me, although there should probably be MOZ_PLATFORM_HILDON and MOZ_PLATFORM_MAEMO since there are a couple things we need to do for maemo that aren't for other hildon platforms.
That's fine. It'll be a significant help to people reading the code.
Comment on attachment 336603 [details] [diff] [review] v2 looks like this has bitrotted quite a bit