453437 - NewAPI: Add support for evaluating JavaScript

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, enhancement)

Description

[Pelle Johnsen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: 

It should be possible (and easy) to evaluate JavaScript from an embedding app. using the new API.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Pelle Johnsen]

Attachment: Add EvaluateJS method to MozView

Added initial patch.

Not to happy about all the string handling, but the plan with the new API was to return strings using utf-8 char* which the caller should be responsible for freeing.

Comment 2

[Pelle Johnsen]

Attachment: Updated to set ScriptObject and Principal properly

Updated patch after comments from mbrkaplan to set ScriptObject and Principal correctly. Ready for review.

Comment 3

[Christopher Blizzard (:blizzard)]

Can you add to the doc around the API that the string you pass in should be in UTF-8?  It's implied by the code, but we should make it explicit in the docs as well.

Also, awesome!

Comment 4

[Pelle Johnsen]

Attachment: Updated doxygen comments to specify utf-8 strings

Updated patch to include utf-8 in doxygen comments

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 339417 [details] [diff] [review]
Updated doxygen comments to specify utf-8 strings

I was trying to determine if we should return a string or a variant-ish kind of object from EvaluateJS, but the underlying method does return a string.

One nit: Can we rename the method to EvaluateScript or EvaluateJavaScript? I'm not a bugu fan of abbreviations in code names.

Comment 6

[Pelle Johnsen]

Pushed to incubator/embedding, with method renamed to EvaluateJavaScript