453521 - range.extractContents should return empty document fragment if range is collapsed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Currently we return null.
Patch coming. With the patches for bug 302775 and bug 42976, ACID3 test7 is fixed.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 336712 [details] [diff] [review]
proposed patch

>-    return CollapseRangeAfterDelete(this);
>+    rv = CollapseRangeAfterDelete(this);
>+    if (NS_SUCCEEDED(rv) && aFragment) {
>+      NS_ADDREF(*aFragment = retval);
>+    }
>+    return rv;

The following is somewhat easier to read and would translate better if we ever switch to real exceptions:

rv = CollapseRangeAfterDelete(this);
NS_ENSURE_SUCCESS(rv, rv);

if (aFragment) {
  NS_ADDREF(*aFragment = retval);
}
return NS_OK;

Up to you