Closed Bug 453521 Opened 15 years ago Closed 15 years ago

range.extractContents should return empty document fragment if range is collapsed

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

proposed patch
4.00 KB, patch
sicking
: review+
sicking
: superreview+
Details | Diff | Splinter Review 
Currently we return null.
Patch coming. With the patches for bug 302775 and bug 42976, ACID3 test7 is fixed.
Attached patch proposed patch — — Splinter Review 
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED

        Attachment #336712 -
        Flags: superreview?(jonas)

        Attachment #336712 -
        Flags: review?(jonas)

    
    

    
  
Comment on attachment 336712 [details] [diff] [review]
proposed patch

>-    return CollapseRangeAfterDelete(this);
>+    rv = CollapseRangeAfterDelete(this);
>+    if (NS_SUCCEEDED(rv) && aFragment) {
>+      NS_ADDREF(*aFragment = retval);
>+    }
>+    return rv;

The following is somewhat easier to read and would translate better if we ever switch to real exceptions:

rv = CollapseRangeAfterDelete(this);
NS_ENSURE_SUCCESS(rv, rv);

if (aFragment) {
  NS_ADDREF(*aFragment = retval);
}
return NS_OK;

Up to you

        Attachment #336712 -
        Flags: superreview?(jonas)

        Attachment #336712 -
        Flags: superreview+

        Attachment #336712 -
        Flags: review?(jonas)

        Attachment #336712 -
        Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Component: DOM: Traversal-Range → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.