reftest reference pngs for ACID2 test and APNG have embedded color profiles

RESOLVED FIXED

Status

()

Core
GFX: Color Management
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Bobby Holley (parental leave - send mail for anything urgent), Assigned: Bobby Holley (parental leave - send mail for anything urgent))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

For some reason our reference PNG has an embedded profile called "Color LCD". This seems like an accident, and it breaks the reftest when color management is turned on. I'll put up a patch with the profile stripped off in a few hours.
Created attachment 336749 [details] [diff] [review]
fix

patch to strip the profile. Reftest passes with CM on and off now.
Attachment #336749 - Flags: review?(vladimir)
Summary: reftest reference png for ACID2 test has an embedded color profile → reftest reference pngs for ACID2 test and APNG have embedded color profiles
Created attachment 336754 [details] [diff] [review]
updated fix to handle apng issue also

Problem also found to exist for APNG test. Adding a fix for that. Vlad told me just to r it myself.
Attachment #336749 - Attachment is obsolete: true
Attachment #336754 - Flags: review?(bholley)
Attachment #336749 - Flags: review?(vladimir)
Attachment #336754 - Flags: review?(bholley) → review+
pushed in f3216177949d.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: GFX → GFX: Color Management
Product: Core Graveyard → Core
QA Contact: general → color-management
You need to log in before you can comment on or make changes to this bug.