453599 - shredder release notes menu item should point to a URL explaining that there aren't any

Status: RESOLVED FIXED

(www.mozilla.org Graveyard :: Thunderbird, defect)

Description

[David Ascher (:davida)]

just to be complete.

Comment 1

[Magnus Melin [:mkmelin]]

Should be handled server side, no?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #1)
> Should be handled server side, no?

Its probably easier to handle it server side, especially considering alphas which we ship unbranded.

At the moment, the URL is:

http://www.mozillamessaging.com/%LOCALE%/%APP%/%VERSION%/releasenotes/

which means we don't need redirects setting up each time.

gozer, is there a way we could do it so that any %VERSION% that isn't found maps to a specific page?

Comment 4

[Philippe M. Chiasson (:gozer)]

yes, very easily, all I'd need to know is what url to redirect to when a specific releasenotes document isn't found.

Comment 5

[Philippe M. Chiasson (:gozer)]

Ping? 

Should I just open a new bug "author web page explaing why there are no releases notes available" ?

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> Ping? 
> 
> Should I just open a new bug "author web page explaing why there are no
> releases notes available" ?

Sorry, I was going to create a web page after Alpha 3 to do this and haven't done it yet. I'll try and do it before Tuesday.

Comment 7

[Mark Banner (:standard8)]

Attachment: Initial Version

I knocked this up quickly whilst waiting for builds to compile. I think keeping it simple is probably best.

Comment 8

[Mark Banner (:standard8)]

Checked into trunk: Committed revision 21651. Can be viewed at:

http://trunk.mozillamessaging.com/en-US/thunderbird/nightly/releasenotes/

Will move it forward tomorrow.

Comment 9

[Mark Banner (:standard8)]

Now on staging: Committed revision 21663.

http://stage.mozillamessaging.com/en-US/thunderbird/nightly/releasenotes/

Comment 10

[Philippe M. Chiasson (:gozer)]

catch-all redirect on
http://live.mozillamessaging.com/thunderbird/releasenotes?
to
http;//www.mozillamessaging.com/en-US/thunderbird/nightly/releasenotes/

Deployed

Comment 11

[Mark Banner (:standard8)]

http://www.mozillamessaging.com/en-US/thunderbird/nightly/releasenotes/

Committed revision 21684.

I now need to do the change for the url within Thunderbird.

Comment 12

[Mark Banner (:standard8)]

Attachment: Change the release notes url

Requesting review from

a) gozer - to check I've got the url format to his liking (the redirects work, but just check the rest of it)
b) Phil - Looking at how Firefox does its release notes preference it has it in its firefox-branding.js prefs file, this one is in just our generic prefs file. So I'd be tempted to move it to thunderbird-branding.js however, both of our thunderbird-branding.js pref files are exactly the same so it doesn't seem worth it (or almost seems like we should just move back to one file). Thoughts?

Comment 13

[Philippe M. Chiasson (:gozer)]

Comment on attachment 358374 [details] [diff] [review]
Change the release notes url

URL looks good to me.

Comment 14

[Phil Ringnalda (:philor)]

Comment on attachment 358374 [details] [diff] [review]
Change the release notes url

I probably wouldn't object if I had a patch in front of me to merge the -branding.js files back in, but I don't think I'd tell someone it was worth the time to patch: we're probably at least as likely to want to be able to do something differently for official builds as we are to forget that we have some other URLs tucked away elsewhere.

Comment 15

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/33581ce31913

This should all be fixed in the next nightlies.