453728 - TM: Can't trace reading .prototype

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Andreas Gal :gal]

It seems .prototype has a non-stub getter (why?) and we fall off trace trying to read it.

Comment 1

[Brendan Eich [:brendan]]

Ancient inefficient overloading of the class getter, fun_getProperty. I fix!

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: proposed fix

Andreas, please check this out ASAP and lemme know if it doesn't cure all abort on function property ills.

/be

Comment 3

[Andreas Gal :gal]

I think this fixed all the cases I am aware of. mrbkap, could you review and push into TM?

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/b06fc042e687

I accidentally pushed some random cleanup in with brendan's patch. I'm pretty sure he won't mind ;-)

Comment 5

[Brendan Eich [:brendan]]

I've been resolving bugs as fixed only when the patch hits m-c. Not sure what is best but that's traditional, so onlookers can try the "trunk" nightlies. But we have TraceMonkey continuous builds too, don't we?

Anyhoo, fixed in mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/bc244c4d2fbd

/be

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Well, IMO it is worth tracking what's been patched. If we push tracemonkey to m-c often enough (say, once a day before the nightlies), then marking bugs as fixed when they hit tracemonkey wouldn't be too bad of a lie.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

(just marking the whiteboard status for driving purposes; we've reached that part of the release cycle where I'm reloading these lists a lot)