453855 - Exception dialog slow to appear when prefetching

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Johnathan Nightingale [:johnath]]

If the exception dialog is invoked with a location pre-populated and with args[0].prefetchCert == true, it will attempt to load the cert synchronously in the onload handler for the dialog.  The effect of this is that the dialog will not be visible until the network call completes, which might be several seconds after invocation.  This makes the application appear unresponsive.

Instead, the onload handler should schedule a timer to perform the fetch, and display immediately with the "Currently verifying certificate..." text.  This allows the dialog to appear more immediately after requested, and has the additional advantage that, even in the case of prepopulated cert exceptions, the user has a few seconds to see the un-cluttered dialog before exception adding is enabled.

Should be a straightforward patch, I'll try to attach one shortly.

Comment 1

[Johnathan Nightingale [:johnath]]

Attachment: 2s timer, update text immediately

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 337097 [details] [diff] [review]
2s timer, update text immediately

I don't mind this patch, but 2 seconds seem pretty long. Have you tested with other values? I would have expected that 100 ms should be sufficient to decouple it.

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 337097 [details] [diff] [review]
2s timer, update text immediately

r=kaie

Please add a comment where you mention the motivation for the 2 seconds timeout (as you said it's not a technical motivation, but the desire to have the user take a look)

On the other hand the argument for prefetching was: people want to save time...

Comment 4

[Johnathan Nightingale [:johnath]]

Attachment: Now with 30% more comments!

Carrying forward r+, commented as suggested.

Comment 5

[Johnathan Nightingale [:johnath]]

http://hg.mozilla.org/mozilla-central/rev/5df24bfd84c1