If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

()

Core
XPConnect
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: (dormant account), Assigned: (dormant account))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 337133 [details] [diff] [review]
xpconnect fixes
Attachment #337133 - Flags: review?(jorendorff)
Attachment #337133 - Flags: superreview?(jst)
Attachment #337133 - Flags: review?(jorendorff)
Attachment #337133 - Flags: review+
Comment on attachment 337133 [details] [diff] [review]
xpconnect fixes

The changes in xpcconvert.cpp are unnecessary because the value being returned is a JSBool, which is already guaranteed (by the API, anyway) to be 1 or 0.  Please don't make that change.

The other changes are good.
(Assignee)

Comment 2

9 years ago
Pushed rev 41a61ce08b26. Sorry, I didn't notice you set superreview?(jst). The remaining changes are safe, so I'll let them be.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Attachment #337133 - Flags: superreview?(jst) → superreview+
Comment on attachment 337133 [details] [diff] [review]
xpconnect fixes

sr=mrbkap on what was already pushed.

Updated

6 years ago
Assignee: nobody → tglek
You need to log in before you can comment on or make changes to this bug.