Closed
Bug 453892
Opened 16 years ago
Closed 16 years ago
prbool bugs in xpconnect
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file)
|
2.25 KB,
patch
|
jorendorff
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #337133 -
Flags: review?(jorendorff)
|
||
Updated•16 years ago
|
Attachment #337133 -
Flags: superreview?(jst)
Attachment #337133 -
Flags: review?(jorendorff)
Attachment #337133 -
Flags: review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 337133 [details] [diff] [review] xpconnect fixes The changes in xpcconvert.cpp are unnecessary because the value being returned is a JSBool, which is already guaranteed (by the API, anyway) to be 1 or 0. Please don't make that change. The other changes are good.
|
Assignee | |
Comment 2•16 years ago
|
||
Pushed rev 41a61ce08b26. Sorry, I didn't notice you set superreview?(jst). The remaining changes are safe, so I'll let them be.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Attachment #337133 -
Flags: superreview?(jst) → superreview+
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 337133 [details] [diff] [review] xpconnect fixes sr=mrbkap on what was already pushed.
|
||
Updated•13 years ago
|
Assignee: nobody → tglek
You need to log in
before you can comment on or make changes to this bug.
Description
•