453970 - history sidebar crashed when i try to delete history

Status: RESOLVED DUPLICATE of bug 434788

(Firefox :: Bookmarks & History, defect)

Description

[dknsf88]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 (.NET CLR 3.5.30729)

when i try to delete a history on the history sidebar, Firefox crashed.

Reproducible: Sometimes

Steps to Reproduce:
1.
2.
3.

Comment 1

[Matthias Versen [:Matti]]

read http://mversen.de/crash/

Comment 2

[Matthew Kidd]

I see this bug frequently and find it very irritating. I have never been able to reproduce it, but deleting a dozen individual history items and/or sites (I have them arranged By Date and Site) is often enough to trigger this bug. I was hoping it would be fixed in latest version but I still see it in Firefox 3.0.2. The problem seems to most frequently occur on line 3631 of nsNavHistory.cpp

  ENUMERATE_WEAKARRAY(mObservers, nsINavHistoryObserver, OnEndUpdateBatch())

The following is a representative crash report (from me):
http://crash-stats.mozilla.com/report/index/7635bfcf-59bd-11dd-9e7e-001cc45a2ce4

Comment 3

[Matthew Kidd]

Here is crash at the same place from Firefox 3.0.2 (from last night)
http://crash-stats.mozilla.com/report/index/c3d5fb33-8a0e-11dd-9d9b-001a4bd43ef6

Comment 4

[Matthias Versen [:Matti]]

both stacks are :
0  	xul.dll  	xul.dll@0x261bde  	
1 	xul.dll 	nsNavHistory::EndUpdateBatch 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3631
2 	xul.dll 	nsNavHistory::RemovePagesFromHost 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3933
3 	xul.dll 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
4 	xul.dll 	XPCWrappedNative::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2393

Comment 5

[Matthew Kidd]

And again with Firefox 3.0.2 on a third computer
http://crash-stats.mozilla.com/report/index/2f0a043d-8c4b-11dd-bbf9-001cc45a2ce4

Same location. The stack is slightly different  (RemovePagesByTimeFrame instead of RemovePagesFromHost) but conceptually the same. In this case, I had deleted the Today history item, expanded the Yesterday history item and then deleted the first three or four consecutive Date/Site pairs when the crash occurred.
0  	xul.dll  	nsNavHistory::EndUpdateBatch  	 mozilla/toolkit/components/places/src/nsNavHistory.cpp:3631
1 	xul.dll 	nsNavHistory::RemovePagesByTimeframe 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3984
2 	xul.dll 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
3 	xul.dll 	XPCWrappedNative::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2393

I think we can safely change the bug status to New.

Comment 6

[Matthew Kidd]

Here is another example, this time with Firefox 3.0.3
http://crash-stats.mozilla.com/report/pending/82914814-8d87-11dd-b268-001a4bd43ef6

This time the stack has only one frame!
0  	 	@0x12fc0e

Perhaps this different result provides an additional clue. The difference here might be that the crash occurred when I tried to delete a single history item (URL) as opposed to a Date/Site or Date item. Then again, I had deleted a bunch of Date/Site items prior to the crash, so if it is a memory corruption issue, the damage may already have been done.

Comment 7

[Matthew Kidd]

And again with Firefox 3.0.3 at the usual EndUpdateBatch location.
http://crash-stats.mozilla.com/report/index/cb6c68dc-8d89-11dd-aab7-001a4bd43ef6?p=1

0  	xul.dll  	nsNavHistory::EndUpdateBatch  	 mozilla/toolkit/components/places/src/nsNavHistory.cpp:3631
1 	xul.dll 	nsNavHistory::RemovePagesFromHost 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3933
2 	xul.dll 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
3 	xul.dll 	XPCWrappedNative::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2393

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv