Last Comment Bug 453979 - nsIMsgIncomingServer isSecureServer attribute obsolete
: nsIMsgIncomingServer isSecureServer attribute obsolete
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 13.0
Assigned To: :aceman
:
:
Mentors:
Depends on:
Blocks: 435775
  Show dependency treegraph
 
Reported: 2008-09-06 09:47 PDT by David :Bienvenu
Modified: 2012-03-28 00:38 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (6.02 KB, patch)
2012-02-29 12:37 PST, :aceman
no flags Details | Diff | Splinter Review
patch v2, uuid change (6.60 KB, patch)
2012-03-01 11:47 PST, :aceman
mozilla: review+
Pidgeot18: feedback+
Details | Diff | Splinter Review

Description David :Bienvenu 2008-09-06 09:47:12 PDT
No one uses this so it can be removed.
Comment 1 Ben Bucksch (:BenB) 2008-09-06 19:15:32 PDT
It also does not seem to do anything.
Comment 2 Joshua Cranmer [:jcranmer] 2008-09-07 05:51:49 PDT
I'm removing this in my work with bug 435775:
http://hg.mozilla.org/users/Pidgeot18_gmail.com/trunk_mq/file/tip/rmserver#l431
Comment 3 :aceman 2012-02-29 11:39:10 PST
jcranmer, dbienvenu, I could try to do this bug. But I can't do the full range of bug 435775. Would it be OK?
Comment 4 Joshua Cranmer [:jcranmer] 2012-02-29 11:56:51 PST
Go for it; I've not done any work on bug 435775 for a long time.
Comment 5 :aceman 2012-02-29 12:08:21 PST
Thanks.
Comment 6 :aceman 2012-02-29 12:37:03 PST
Created attachment 601715 [details] [diff] [review]
patch

I remove the member variable.
I also remove also the GetIsSecureServer methods where found. They were not using the variable, but they do not seem to be called from anywhere either.
Should this line be removed too?
base/ispdata/aol.rdf:            <NC:isSecureServer>false</NC:isSecureServer>
Comment 7 :aceman 2012-02-29 12:43:56 PST
Yeah, I'll update the uuid in the next version.
Comment 8 Ben Bucksch (:BenB) 2012-02-29 14:22:46 PST
aceman: aol.rdf, gmail.rdf and README in ispdata/ should all be entirely removed.
Comment 9 David :Bienvenu 2012-02-29 14:30:20 PST
(In reply to Ben Bucksch (:BenB) from comment #8)
> aceman: aol.rdf, gmail.rdf and README in ispdata/ should all be entirely
> removed.

as long as SeaMonkey doesn't use them (I don't think it does)
Comment 10 Ben Bucksch (:BenB) 2012-02-29 14:50:27 PST
Yeah, up to Neil. At minimum aol.rdf and README should be removed, because there's no point to special-case AOL.
Comment 11 David :Bienvenu 2012-02-29 14:59:17 PST
last I checked, SeaMonkey isn't using the new autoconfig (which is irrelevant if it's not using the ispdata either)
Comment 12 Mark Banner (:standard8, limited time in Dec) 2012-02-29 15:02:18 PST
(In reply to David :Bienvenu from comment #11)
> last I checked, SeaMonkey isn't using the new autoconfig (which is
> irrelevant if it's not using the ispdata either)

SM (and ourselves!) use it for Movemail, but aol.rdf & gmail.rdf and the README can go away happily, xref:

http://mxr.mozilla.org/comm-central/source/mailnews/base/ispdata/Makefile.in
Comment 13 :aceman 2012-03-01 01:51:14 PST
Should I do it in this bug or another one?
Comment 14 :aceman 2012-03-01 11:45:47 PST
There seems to be bug 732106 for that.
Comment 15 :aceman 2012-03-01 11:47:45 PST
Created attachment 602053 [details] [diff] [review]
patch v2, uuid change
Comment 16 David :Bienvenu 2012-03-05 11:27:21 PST
Comment on attachment 602053 [details] [diff] [review]
patch v2, uuid change

thx for the patch
Comment 17 Ryan VanderMeulen [:RyanVM] 2012-03-05 17:02:14 PST
http://hg.mozilla.org/comm-central/rev/4ce2a7788011

Note You need to log in before you can comment on or make changes to this bug.