nsIMsgIncomingServer isSecureServer attribute obsolete

RESOLVED FIXED in Thunderbird 13.0

Status

MailNews Core
Networking
--
minor
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: Bienvenu, Assigned: aceman)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 13.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

6.60 KB, patch
Bienvenu
: review+
jcranmer
: feedback+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
No one uses this so it can be removed.

Comment 1

9 years ago
It also does not seem to do anything.
I'm removing this in my work with bug 435775:
http://hg.mozilla.org/users/Pidgeot18_gmail.com/trunk_mq/file/tip/rmserver#l431
(Assignee)

Comment 3

6 years ago
jcranmer, dbienvenu, I could try to do this bug. But I can't do the full range of bug 435775. Would it be OK?
Go for it; I've not done any work on bug 435775 for a long time.
(Assignee)

Comment 5

6 years ago
Thanks.
Assignee: dbienvenu → acelists
Severity: normal → minor
Target Milestone: Thunderbird 3.0b1 → ---
Version: unspecified → Trunk
(Assignee)

Comment 6

6 years ago
Created attachment 601715 [details] [diff] [review]
patch

I remove the member variable.
I also remove also the GetIsSecureServer methods where found. They were not using the variable, but they do not seem to be called from anywhere either.
Should this line be removed too?
base/ispdata/aol.rdf:            <NC:isSecureServer>false</NC:isSecureServer>
Attachment #601715 - Flags: review?(dbienvenu)
Attachment #601715 - Flags: feedback?(Pidgeot18)
(Assignee)

Comment 7

6 years ago
Yeah, I'll update the uuid in the next version.

Comment 8

6 years ago
aceman: aol.rdf, gmail.rdf and README in ispdata/ should all be entirely removed.
(Reporter)

Comment 9

6 years ago
(In reply to Ben Bucksch (:BenB) from comment #8)
> aceman: aol.rdf, gmail.rdf and README in ispdata/ should all be entirely
> removed.

as long as SeaMonkey doesn't use them (I don't think it does)

Comment 10

6 years ago
Yeah, up to Neil. At minimum aol.rdf and README should be removed, because there's no point to special-case AOL.
(Reporter)

Comment 11

6 years ago
last I checked, SeaMonkey isn't using the new autoconfig (which is irrelevant if it's not using the ispdata either)
(In reply to David :Bienvenu from comment #11)
> last I checked, SeaMonkey isn't using the new autoconfig (which is
> irrelevant if it's not using the ispdata either)

SM (and ourselves!) use it for Movemail, but aol.rdf & gmail.rdf and the README can go away happily, xref:

http://mxr.mozilla.org/comm-central/source/mailnews/base/ispdata/Makefile.in
(Assignee)

Comment 13

6 years ago
Should I do it in this bug or another one?
(Assignee)

Comment 14

6 years ago
There seems to be bug 732106 for that.
(Assignee)

Comment 15

6 years ago
Created attachment 602053 [details] [diff] [review]
patch v2, uuid change
Attachment #601715 - Attachment is obsolete: true
Attachment #602053 - Flags: review?(dbienvenu)
Attachment #602053 - Flags: feedback?(Pidgeot18)
Attachment #601715 - Flags: review?(dbienvenu)
Attachment #601715 - Flags: feedback?(Pidgeot18)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Attachment #602053 - Flags: feedback?(Pidgeot18) → feedback+
(Reporter)

Comment 16

6 years ago
Comment on attachment 602053 [details] [diff] [review]
patch v2, uuid change

thx for the patch
Attachment #602053 - Flags: review?(dbienvenu) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/4ce2a7788011
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
(Assignee)

Updated

6 years ago
Blocks: 435775
You need to log in before you can comment on or make changes to this bug.