Closed Bug 454011 Opened 16 years ago Closed 16 years ago

[10.5] Cells in Certificates window columns are semi-editable

Categories

(Camino Graveyard :: Security, defect)

All
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: chris)

Details

(Keywords: polish)

Attachments

(1 file, 3 obsolete files)

This is actually the worst of them so far: you can actually type in the cells :P  As with the others, though, exiting the cell clears your edit.

I can't quite tell where this column is set up, but presumably any of our Obj-C coders can find and fix it trivially.
Actually, cells in the right side outline view are also semi-editable; you just have to hit return on them (the click trick doesn't work there).  

Adjusting the summary to cover both table/outline views.
Summary: [10.5] Cells in "Category" column in Certificates window are semi-editable → [10.5] Cells in Certificates window columns are semi-editable
Hardware: Macintosh → All
Attached patch Fix v1.0 (obsolete) — Splinter Review
Programmatically sets the Categories column to be non-editable.
Tells the ExtendedOutlineView to be non-editable. Adds a check in ExtendedOutlineView to check if it is editable when the user presses Return (not Enter). Doesn't break Bookmarks, AFAICT.
Attachment #337243 - Flags: review?
Attachment #337243 - Flags: review? → review?(murph)
Assignee: nobody → trendyhendy2000
Attachment #337243 - Flags: review?(murph) → review+
Comment on attachment 337243 [details] [diff] [review]
Fix v1.0

>+  [[[mCategoriesTable tableColumns] objectAtIndex:0] setEditable:NO];

Since this table column is in the nib, I think we should just set its editing attribute from within IB.

>+        if (mAllowsEditing && ([self numberOfSelectedRows] == 1))

The ExtendedOutlineView seems to handle cell editing in its own unique way, overriding mouse and key down methods, rather than letting the parent control take care of this behavior based upon -[NSTableColumn isEditable].  I'm guessing this manual editing code was added to allow such behavior before Apple introduced the it in newer releases.  I would rather see us avoid the mAllowsEditing variable, and instead control editing status from the nib, with the code to support keyDown: editing similar to what I did previously in ExtendedTableView: <http://mxr.mozilla.org/mozilla/source/camino/src/extensions/ExtendedTableView.mm#89>, but such a change beyond the scope of this bug though.  I guess it's fine to keep controlling editing using our own logic.

r=me with the first item changed; The second issue will need a separate bug if we want to change the way that works.
Attached patch Fix v1.1Splinter Review
Addresses reviewer's comments. Fixed nib in another attachment.
Attachment #337243 - Attachment is obsolete: true
Attachment #337564 - Flags: superreview?(stuart.morgan+bugzilla)
Attached file Fixed Certificates Window nib (obsolete) —
Nib with the categories table column set to non-editable. Saved with IB3 on 10.5.
Attachment #337567 - Flags: superreview?(stuart.morgan+bugzilla)
Attached file Same nib, avoiding IB3 (obsolete) —
Here's the nib edited in IB 2.5.6 to avoid any IB3 unpleasantness. 3s editing in GA > 14 hrs downloading in NZ ;)
Attachment #337567 - Attachment is obsolete: true
Attachment #337567 - Flags: superreview?(stuart.morgan+bugzilla)
Comment on attachment 337564 [details] [diff] [review]
Fix v1.1

sr=smorgan
Attachment #337564 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
The header of the Categories table view needs to be widened so it takes up the whole table.
Landed on cvs trunk.

Since IB 2.5.6 seems incapable of editing that column without messing with the column width (because it always pops in the scrollbar in the scrollview), I took the IB 3 nib, opened it in IB 2.5.6 and simply re-saved it.  That gets us a 2.x nib with the proper column width.

Please do file the follow-up on possibly removing EOV.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: