454024 - "ftp:///" (no hostname) gives an empty list of files instead of an error

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Jesse Ruderman]

1. Load ftp:///

Result: an empty list of files

Expected: an error message telling me that's a bogus URL or something

Comment 1

[Matthias Versen [:Matti]]

I get a blank page and an empty list if i load the the url again but that is bug 406787

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I see this in FF 3.0.1 on OS X, Windows and Linux.  I don't see it in
FF2.

On Linux it always happens (in FF 3.0.1).

But on OS X and Windows I see the following:

1) If I right-click on the ftp:/// URL and choose "open in another
   tab", I get a blank tab.

2) If I just click on the ftp:/// URL I get an empty list of files.

3) And very strangely, once I've performed step 2, even performing
   step 1 now always gives me an empty list of files ... until I
   restart the browser.

Comment 3

[Matthias Versen [:Matti]]

Could you retest with a nightly because bug 406787 could have fixed the empty file list.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Oops, sorry.

Testing with today's Minefield nightly (on OS X 10.5.4) I no longer
see this problem.  Either nothing happens, or a blank page opens in a
new tab.

Comment 5

[Tautvydas Andrikys]

Attachment: fix

Comment 6

[Jason Duell]

Comment on attachment 459136 [details] [diff] [review]
fix

Review of attachment 459136 [details] [diff] [review]:
-----------------------------------------------------------------

I also get a blank screen with nightly, which is better than an empty file list, but I think the error screen we get when we use this patch is better.  Sorry for taking so long to review this.  I'll take care of landing it.

Comment 7

[Jason Duell]

landed on inbound:

  https://hg.mozilla.org/integration/mozilla-inbound/rev/c3e98453fc95

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/c3e98453fc95