454054 - Some links point to http from https session.

Status: RESOLVED DUPLICATE of bug 329638

(Bugzilla :: Bugzilla-General, defect)

Description

[Marek Fort]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: 3.0.5

We use bugzilla in our intranet, for this access we use HTTP.
Sometimes, we use the the same server from outside, using HTTPS.

Some links in bugzilla seems to be hardcoded to use HTTP instead of building the dynamicaly.

Case #1:
bug report (https://XXXX/bugzilla/show_bug.cgi?id=NNN)
See Bug Detail, Bug#. The number itself points always to http.

Case #2: Quick Search for bug. 
If I enter a bug number, I am redirected to 
  http://XXXX/bugzilla/show_bug.cgi?id=NNN (always HTTP)
If the result contains more bug reports, I am redirected to buglist.cgi that is 
correct (http or https).

Case #3:
Install the Quick Search plugin. 
The url argument to AddSearchProvider(url) is always HTTP.

Case #4:
Install SideBar. Same as case#2, always http, this issue is pretty easy to fix in bookmark manager. But still, the page sidebar.cgi always redirects to HTTP.


All the issues have common result, the page never loads. Thats because the HTTP access to that computer is not allowed in firewall.



Reproducible: Always

Steps to Reproduce:
1. install http and https server 
2. disable https in firewall
3. see case#1 - 4 in details
Actual Results:  
page never loads


Expected Results:  
page loaded

similar to bug#329638, see comment #4

Comment 1

[Frédéric Buclin]

(In reply to comment #0)
> similar to bug#329638, see comment #4

How is this bug different from bug 329638? That's a duplicate, as far as I can see. Also, what's the value of the 'ssl' parameter?

Comment 2

[Marek Fort]

my "ssl" parameter is set to 'never'.
I need to use HTTP as well. 

Why not a duplicate of bug#329638 ?

Well the bugzilla WORKS very well at 98% . 
So I cannot claim I cannot use bugzilla from https at all (as reported in that bug report.) 
I explicitly described what exact features are not working properly.

Probably only those 4 cases are not handled correctly. the cases 1,3,4 are very minor, only the case 2 is the most important to fix.

Everything else works like a charm.

This bug report applies to bugzilla  3.0.1 - 3.0.5. 
Not tested on other releases.

Comment 3

[Marek Fort]

Attachment: patch file for Bugzilla/Search/Quicksearch.pm

I've looked in the code (never worked with Perl), 
and made a simple fix to case 2.

Please check if this patch is compatible with the rest of the code.

See attachment 1 [details] [diff] [review].

Comment 4

[Marek Fort]

It is a duplicate, sorry.