454085 - MathML does not render properly with text-align:indent

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008071618 Iceweasel/3.0.1 (Debian-3.0.1-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008071618 Iceweasel/3.0.1 (Debian-3.0.1-1)

Unexpected spaces appear in formulae when one uses text-align:indent

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Frédéric Wang (:fredw)]

Attachment: testcase

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Add a text-indent:0 in mtable to prevent unexpected spaces. [Checkin: Comment 12]

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 337434 [details] [diff] [review]
Add a text-indent:0 in mtable to prevent unexpected spaces.
[Checkin: Comment 12]

Thanks, Frédéric.
I'm just trying to think whether maybe we should be doing this on the mtd or even on the anonymous nsMathMLmtdInnerFrame block frame.  It only makes a difference though if someone is going to set text-indent on an mtable, mtr, or mtd.  What do you think, Rob?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 337434 [details] [diff] [review]
Add a text-indent:0 in mtable to prevent unexpected spaces.
[Checkin: Comment 12]

Let's do it on <mtable>, since the equivalent rule in html.css is on <table>.

Comment 5

[Frédéric Wang (:fredw)]

Attachment: Bug when <math> is in an SVG foreignObject

Comment 6

[Frédéric Wang (:fredw)]

The previous attachment show the bug of text-indent when the <math> is inside a foreignObject: the formulae are shift to the right. Here again, it is fixable by attaching a text-indent:0 to -moz-svg-foreign-content

Comment 7

[Frédéric Wang (:fredw)]

Attachment: Add a text-indent:0 to prevent the shift [Checkin: Comment 12]

Comment 8

[Karl Tomlinson (:karlt)]

One thing to consider here is whether html within a foreignObject should inherit text-indent.

It looks like the issue in attachment 337632 [details] might be due to the <foreignObject> creating a block context for the inline <math>.  Maybe it needs to do that...

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 337654 [details] [diff] [review]
Add a text-indent:0 to prevent the shift
[Checkin: Comment 12]

It does need to use a block. I think this is right; <svg> should behave like <table> here.

Comment 10

[Frédéric Wang (:fredw)]

Can someone commit my two patches, please?

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's marked checkin-needed so that should happen reasonably soon.

Comment 12

[Karl Tomlinson (:karlt)]

Checked these in, thank you:

http://hg.mozilla.org/mozilla-central/rev/2eef7a07820a
http://hg.mozilla.org/mozilla-central/rev/1b64769375b2