Closed Bug 454108 Opened 11 years ago Closed 11 years ago

Update Hunspell to version 1.2.8

Categories

(Core :: Spelling checker, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla1.9.1b2

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Update Hunspell 1.1.12 to 1.2.7 (obsolete) — Splinter Review
The current version of Hunspell in the tree is version 1.1.12. Hunspell has since been gone through numerous updates, the latest being 1.2.7, with many important fixes going in. Memory usage has improved, suggested replacements have been improved, and many other bugs have been fixed.

This patch applies cleanly to the trunk and compiles fine on both Linux and Windows.

Tryserver builds:
https://build.mozilla.org/tryserver-builds/2008-09-07_13:18-mcsmurf@mcsmurf.de-1220818647/

Scott, can you rubberstamp this?
Attachment #337339 - Flags: superreview?(mscott)
Attachment #337339 - Flags: review?(mscott)
Mike, any word on who's taking over spellchecker? I'd really like to get this in for 3.1b1...
Attachment #337339 - Flags: superreview?(mscott)
Attachment #337339 - Flags: superreview?(mconnor)
Attachment #337339 - Flags: review?(mscott)
Comment on attachment 337339 [details] [diff] [review]
Update Hunspell 1.1.12 to 1.2.7

Per #developers, changing the sr request.
Attachment #337339 - Flags: superreview?(mconnor) → superreview?(dmose)
Comment on attachment 337339 [details] [diff] [review]
Update Hunspell 1.1.12 to 1.2.7

moving this to dmose, who probably can do this sooner than I can (and owes me some mail on updates for the owner here)
Maybe this will solve also bug 422982?
(In reply to comment #4)
> Maybe this will solve also bug 422982?

Unfortunately, this is not a spell-checker, but a tokenizer related problem.
Ryan, I have made an important patch for Hunspell 1.2.7, it removes some incorrect spelling suggestions:

http://sourceforge.net/tracker/index.php?func=detail&aid=2124186&group_id=143754&atid=756395

Best regards, László
Comment on attachment 337339 [details] [diff] [review]
Update Hunspell 1.1.12 to 1.2.7

I'm told that 1.2.8 is coming very shortly, so you're off the hook for now, dmose :)
Attachment #337339 - Flags: superreview?(dmose)
Ryan, is there perhaps a list of changes between 1.1.12 - 1.2.8?
Are there any new things which might require a security review?
Smaug, detailed changelogs are available on the project's SourceForge page.

1.2 (1.2.1) - http://sourceforge.net/project/shownotes.php?release_id=551113&group_id=143754
1.2.2 - http://sourceforge.net/project/shownotes.php?release_id=569065&group_id=143754
1.2.3 - http://sourceforge.net/project/shownotes.php?release_id=607512&group_id=143754
1.2.4 - http://sourceforge.net/project/shownotes.php?release_id=607577&group_id=143754
1.2.5 - http://sourceforge.net/project/shownotes.php?release_id=612345&group_id=143754
1.2.6 - http://sourceforge.net/project/shownotes.php?release_id=613618&group_id=143754
1.2.7 - http://sourceforge.net/project/shownotes.php?group_id=143754&release_id=619954
1.2.8 - Not released yet. I'll post a link to the changelog when it is.

Some new components have been added, such as the hunzip library, so it may require security review. I really don't know what the criteria are for determining that, though. I suppose the sooner I can get someone to look at the code, the sooner we can get an answer to that.
Seem like there are many good things but also something not so nice:
http://sourceforge.net/project/shownotes.php?release_id=551113&group_id=143754
"Hungarian spell checking is 25% slower on most frequent words of Hungarian Webcorpus."
(In reply to comment #10)
> Seem like there are many good things but also something not so nice:
> http://sourceforge.net/project/shownotes.php?release_id=551113&group_id=143754
> "Hungarian spell checking is 25% slower on most frequent words of Hungarian
> Webcorpus."

25% is indifferent for the normal spell checking. In fact, English spell checking is five times (500%) faster, than Hungarian spell checking (~50 thousand words/sec and ~10 thousand words/sec), thanks to the simple English morphology. Also the suggestion speed depends from the language complexity and the suggestion strategies much better, than the new condition checking algorithm.
Attached patch Fix for comment #6 (obsolete) — Splinter Review
Here's a followup patch for the issue mentioned in comment #6. This applies cleanly over the first patch.

At this point, I don't know if 1.2.8 will be ready in time for the 3.1b2 freeze. Is there any chance we can go ahead and land 1.2.7 with this fix for now?
Target Milestone: mozilla1.9.1b1 → ---
(In reply to comment #12)
> Is there any chance we can go ahead and land 1.2.7 with this fix for
> now?

Hunspell 1.2.8 is out. New features and bug fixes:
https://sourceforge.net/project/shownotes.php?group_id=143754&release_id=637489

Regards, László
László, can you estimate how "stable" 1.2.8 is? How likely there will be regressions from 1.1.12? I was told that OOo 3 uses still 1.1.12 by default,
so I guess 1.2.x isn't tested as well as 1.1.x.

I hope we could take 1.2.8. Ryan, will you have time to create the patch?
1.2.x Hunspell branch is there in several Linux distributions (If I right remember, also in the Hungarian version of OpenOffice.org 2.4) and all detected affix condition checking problems of 1.2.x branch are fixed in Hunspell 1.2.8. There are also 95 other regression test in Hunspell distribution with Valgrind memcheck. I have also successfully checked the spell checking and suggestion on ~100 thousand English words (/usr/share/dict/words). We use Hunspell 1.2 in a full text search database, as indexing engine (the database contains 1 million articles).
Summary: Update Hunspell to version 1.2.7 → Update Hunspell to version 1.2.8
OK, here's a new patch for 1.2.8. I've built this successfully on Windows (and I'm posting this message from the resulting build) and the TryServer built it OK on Linux (the win32 TryServer is on the fritz right now - see bug 462573 for more details)
https://build.mozilla.org/tryserver-builds/2008-11-02_15:37-ehsan.akhgari@gmail.com-hunspell-update/

Smaug, dmose, mconnor - Let me know if you need anything else.
Attachment #337339 - Attachment is obsolete: true
Attachment #345880 - Attachment is obsolete: true
Comment on attachment 345994 [details] [diff] [review]
Update Hunspell 1.1.12 to 1.2.8

If we want to take this, it must happen now. If there are any significant regressions, we shouldn't be reluctant to backout, IMO.
Beta2 should give good enough baking time...

dmose, mconnor, ok to you?
Attachment #345994 - Flags: review+
mconnor said fine by him in #developers
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b2
Depends on: 476332
possible regression in  Bug 525581
You need to log in before you can comment on or make changes to this bug.