454116 - Potential Memory Allocation Failures in WinMobile

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Memory Leak Metering and Shunt debug log file output

We need some way to check on potential memory shortage within XULRunner on WinMobile devices / emulators.

This bug also has a patch attached.  The patch has a very simple memory allocation check, output (to a WinCE shunt debug log file) in a format which allows easy grep and redirect into a comma-delimited file.  The comma-delimited file can then be read into an Excel program (or equivalent) to graphically view total system memory  usage (XULRunner, fennec, and everything else running at the same time).

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 337363 [details] [diff] [review]
Memory Leak Metering and Shunt debug log file output

// comma-delimited-text-file input into excel

what is excel?  use gnuplot, it will save you like 500 dollars.


Where are these defined:
+#ifdef SHUNT_LOG_ENABLED
+    void mozce_DebugInit();
+    void mozce_DebugDeinit();
+    void mozce_DebugWriteToLog(char * str);
+#endif


spacing is off here:
+#ifdef WINCE_MEMORY_CHECKPOINTING
+        MOZCE_SHUNT_API void mozce_MemoryCheckpoint();


otherwise looks fine.

Comment 2

[John Wolfe (:wolfe)]

Attachment: Spacing shifted as requested

I have to check out gnuplot - I have been paying too much for my spreadsheets...

Where are these defined: 
+#ifdef SHUNT_LOG_ENABLED 
+ void mozce_DebugInit(); 
+ void mozce_DebugDeinit(); 
+ void mozce_DebugWriteToLog(char * str); 
+#endif

These functions are defined in a file named mozce_dbg.c -- added by patch 337357 inside bug 444485 - Make WinMobile Build work with Visual Studio 2008 (VS9).

Somehow, my dependency of this bug on the patch from bug 444485 did not get retained.

I will be adding back the dependency as soon as I file this attachment.

Comment 3

[John Wolfe (:wolfe)]

Requires bug patch for adding Visual Studio 9 support to mozilla-central.

Comment 4

[Doug Turner (:dougt)]

checked in on Tue Sep 23 21:10:58 2008 -0700