Closed Bug 454119 Opened 11 years ago Closed 11 years ago

WinMobile Compile Problems with mozilla-central

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Windows Mobile 6 Professional
defect
Not set

Tracking

(Not tracked)

VERIFIED INCOMPLETE
fennec1.0a2

People

(Reporter: wolfe, Assigned: wolfe)

References

Details

(Keywords: mobile)

Attachments

(1 file)

This bug is a catch-all for problems compiling mozilla-central for WinMobile.

This patch covers some unicode issues, some missing API issues, and some it-just-doesn't-work-that-way-on-WinMobile issues.

Most dangerous change in the patch is a delta to CONFIGURE.IN, but changes are limited to a WINCE portion of a switch statement.

This patch is needed to further WinMobile work under mozilla-central.
Attachment #337367 - Flags: review?(doug.turner)
Comment on attachment 337367 [details] [diff] [review]
Catch-all of fixes needed to compile mozilla-central for WinMobile

Hey wolfe.  You really want to split this patch up in to separate patches.

A few notes:  For things like disabling ogg, don't do it in the makefiles -- just --disable-ogg.

the gfx font stuff should go in to its own patch

we need to not change all the constants in mozIStorageError.idl

the nsUXThemeData.cpp stuff should be filed as its own bug and probably switched to use L"..." rather than TEXT()

please split out everything else as well.
Comment on attachment 337367 [details] [diff] [review]
Catch-all of fixes needed to compile mozilla-central for WinMobile

spacing in :

build/wince/tools/vs8ppc2003arm/toolspath.h


is all messed up.  please no tabs, keep spacing the same (2 or four).  It is way hard to review what actually you changed.


why do we need arm-wince-res?

Please split out the configure.in change

Please split out:
gfx/*  Ask stuart for a review.

Please split out:
media/*  Ask chris double for a review.

Please split out:
modules/lcms/*  Ask stuart for a review?  Not sure... maybe someone else.  This change needs to get upstream.

Please split out storage/*.  This is going to be hard.  You might be able to add a c++ block above this code that undefines the keywords?  ugh. ;-)

Split out the toolkit/library/* stuff.  :Bs can review.

Split out the js/src/* changes. 

Same with the widget, and xpcom code, ask me for a review of that.
Flags: blocking-fennec1.0+
Target Milestone: --- → Fennec A2
Assignee: nobody → wolfe
Attachment #337367 - Flags: review?(doug.turner) → review-
we are handling this bug in tigher scoped bugs.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INCOMPLETE
we are building just fine.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.