Use .trim() in Editor/Composer

NEW
Unassigned

Status

SeaMonkey
Composer
--
trivial
10 years ago
6 days ago

People

(Reporter: mikekap, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 337383 [details] [diff] [review]
Patch v1

Fallout of bug 220348.

I actually have no idea if this patch <applies>. I don't have a c-c repo, so if someone wants to take this up - go ahead. attachment 332666 [details] [diff] [review] has a patch that *did* apply, but before the move of editor.
Created attachment 355103 [details] [diff] [review]
(Bv1) s/replace/trim/ only
[Checkin: Comment 3]

This is untested, but should be trivial enough.
Assignee: daniel → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #355103 - Flags: review?(daniel)
Depends on: 305064

Updated

10 years ago
No longer blocks: 220348
Attachment #355103 - Flags: review?(daniel) → review+
Comment on attachment 355103 [details] [diff] [review]
(Bv1) s/replace/trim/ only
[Checkin: Comment 3]

r=me (trivial changes)
Comment on attachment 355103 [details] [diff] [review]
(Bv1) s/replace/trim/ only
[Checkin: Comment 3]

http://hg.mozilla.org/comm-central/rev/fd2b49b65f9f
Attachment #355103 - Attachment description: (Bv1) s/replace/trim/ only → (Bv1) s/replace/trim/ only [Checkin: Comment 3]
(In reply to comment #0)
> Patch v1

Do we really want to inline these 3 functions ?
If yes, we may prefer to use "if (s)  s.trim();" when there is a var !?
Severity: enhancement → trivial
Assignee: bugzillamozillaorg_serge_20140323 → nobody
Status: ASSIGNED → NEW
Component: General → Composer
Product: Composer → SeaMonkey
Version: other → unspecified
You need to log in before you can comment on or make changes to this bug.