Closed
Bug 454129
Opened 16 years ago
Closed 4 years ago
Use .trim() in Editor/Composer
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikekap, Unassigned)
References
Details
Attachments
(2 files)
37.92 KB,
patch
|
Details | Diff | Splinter Review | |
3.00 KB,
patch
|
glazou
:
review+
|
Details | Diff | Splinter Review |
Fallout of bug 220348. I actually have no idea if this patch <applies>. I don't have a c-c repo, so if someone wants to take this up - go ahead. attachment 332666 [details] [diff] [review] has a patch that *did* apply, but before the move of editor.
Comment 1•16 years ago
|
||
This is untested, but should be trivial enough.
Updated•16 years ago
|
Attachment #355103 -
Flags: review?(daniel) → review+
Comment on attachment 355103 [details] [diff] [review] (Bv1) s/replace/trim/ only [Checkin: Comment 3] r=me (trivial changes)
Comment 3•16 years ago
|
||
Comment on attachment 355103 [details] [diff] [review] (Bv1) s/replace/trim/ only [Checkin: Comment 3] http://hg.mozilla.org/comm-central/rev/fd2b49b65f9f
Attachment #355103 -
Attachment description: (Bv1) s/replace/trim/ only → (Bv1) s/replace/trim/ only
[Checkin: Comment 3]
Comment 4•16 years ago
|
||
(In reply to comment #0) > Patch v1 Do we really want to inline these 3 functions ? If yes, we may prefer to use "if (s) s.trim();" when there is a var !?
Severity: enhancement → trivial
Updated•6 years ago
|
Assignee: bugzillamozillaorg_serge_20140323 → nobody
Status: ASSIGNED → NEW
Component: General → Composer
Product: Composer → SeaMonkey
Version: other → unspecified
Comment 5•4 years ago
|
||
The regex is gone and the remaining fucntions can stay I think. So call it closed.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•