454211 - ISimpleDOMNode functions get_computedStyleForProperties and get_computedStyle functions appear to always return the COM error code 0x80004005 (E_FAIL)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Report from GWMicro with both Firefox 3.0.1 and 3.0.3pre.

Comment 1

[alexander :surkov (:asurkov)]

It will return E_FAIL on text nodes, on document. Otherwise it should be ok. How can I test this?

Comment 2

[alexander :surkov (:asurkov)]

previously it worked on text nodes as well (but the current behaviour is from bug 275010, 2006-07-24).

Comment 3

[William Smith]

This is a problem for us because our just released version won't be able to reflect the new definition of needing to consult the parent of text.

We use this method to give our users access to the character attributes of text such as point size, character weight, color etc.

I was hoping that the new features of Firefox 3 wouldn't cause loss of functionality to our accessibility code.

If the parent always has the correct information, is it difficult to notice that the call is on the text node case and forward the request to the parent?

Comment 4

[alexander :surkov (:asurkov)]

Will, of course it's not difficult.  The main thing I concern if the problem is these methods fail on text nodes, no more. That's I was need to know. Thanks.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 339019 [details] [diff] [review]
patch

>+      // text child of html:span element
>+      acc = acc.firstChild.QueryInterface(nsIAccessNode);

Nit: Please protect against possible exceptions here.
With that, r=me for the test.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch2

with Marco's comment

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 339021 [details] [diff] [review]
patch2

One more thing: Could you replace the hardcoded RGB value you compare against with the computed style as shown in accessible/tests/mochitest/test_textattrs.html?

Comment 9

[alexander :surkov (:asurkov)]

Ok, I will

Comment 10

[alexander :surkov (:asurkov)]

checked in http://hg.mozilla.org/mozilla-central/rev/b5596b42ca9a

Comment 11

[alexander :surkov (:asurkov)]

Comment on attachment 339021 [details] [diff] [review]
patch2

needed to improve firefox compatibility with screen readers, it's a regression, includes mochitest

Comment 12

[Daniel Veditz [:dveditz]]

Not "blocking" a branch release but we'll look at the patch. This appears to be fixed in mozilla-central, marking FIXED. (for branch we use keywords, or clone bugs).

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 339021 [details] [diff] [review]
patch2

we need to bring in the 3.0.4 schedule, bumping to next release.

I'm not sure we're going to be comfortable taking accessibility changes on the stable branch when 3.1 is going to be available soon.

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 339021 [details] [diff] [review]
patch2

Approved for 1.9.0.5, a=dveditz for release-drivers

Comment 15

[Marco Zehe (:MarcoZ)]

Checking in accessible/src/base/nsAccessNode.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessNode.cpp,v  <--  nsAccessNode.cpp
new revision: 1.81; previous revision: 1.80
done
Checking in accessible/src/base/nsAccessNode.h;
/cvsroot/mozilla/accessible/src/base/nsAccessNode.h,v  <--  nsAccessNode.h
new revision: 1.50; previous revision: 1.49
done
Checking in accessible/src/base/nsAccessibilityUtils.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityUtils.cpp,v  <--  nsAccessibilityUtils.cpp
new revision: 1.34; previous revision: 1.33
done
Checking in accessible/src/base/nsAccessibilityUtils.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityUtils.h,v  <--  nsAccessibilityUtils.h
new revision: 1.27; previous revision: 1.26
done
Checking in accessible/src/html/nsHTMLTableAccessible.cpp;
/cvsroot/mozilla/accessible/src/html/nsHTMLTableAccessible.cpp,v  <--  nsHTMLTableAccessible.cpp
new revision: 1.66; previous revision: 1.65
done
Checking in accessible/src/msaa/nsAccessNodeWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsAccessNodeWrap.cpp,v  <--  nsAccessNodeWrap.cpp
new revision: 1.46; previous revision: 1.45
done
Checking in accessible/tests/mochitest/Makefile.in;
/cvsroot/mozilla/accessible/tests/mochitest/Makefile.in,v  <--  Makefile.in
new revision: 1.24; previous revision: 1.23
done
RCS file: /cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessNode_utils.html,v
done
Checking in accessible/tests/mochitest/test_nsIAccessNode_utils.html;
/cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessNode_utils.html,v  <--  test_nsIAccessNode_utils.html
initial revision: 1.1
done

Comment 16

[Marco Zehe (:MarcoZ)]

Attachment: Patch that was actually checked into 1.9.0.5 branch

I had to port nsCoreUtils::GetDomElementFor to nsAccUtils::GetDomElementFor to get this patch to compile under 1.9.0.5. This patch is being attached for informational purposes.

Comment 17

[Marco Zehe (:MarcoZ)]

Verified fixed on 1.9.0 branch using Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.5) Gecko/2008120122 Firefox/3.0.5

Comment 18

[Intermittent Failures Robot]

1 failures in 4666 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=454211&startday=2019-08-05&endday=2019-08-11&tree=all

Comment 19

[Intermittent Failures Robot]

2 failures in 4045 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• linux1804-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=454211&startday=2020-02-17&endday=2020-02-23&tree=all