454227 - Media Queries: incorrect EOF handling

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Anne (:annevk)]

Given the default CSS error handling the media query "(min-width,all" should not apply.

Maybe the specification should be slightly more explicit about EOF handling. What do you think?

Tested with: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20080908054322 Minefield/3.1b1pre

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I don't see what this has to do with EOF handling.  CSS 2.1 says that open constructs are closed on EOF, so "all and (min-width: 0" probably should apply, and we ought to test that.

However, this looks like an unparseable expression, so I agree it shouldn't apply.  (However, if we were implementing HTML4's media list parsing rules rather than HTML5's, it would apply in the uses of media lists in HTML.)

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Oh, and your test is actually about "(min-width:,all" (which has a colon in it).

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

There are two changes here:

 (1) accept EOF in addition to ')' to terminate a media query expression that can have no value

 (2) rather than just doing an ExpectSymbol(')') at the end, do a SkipUntil(')') if the next symbol isn't ')'.

It's the latter that fixes Anne's test, but I added tests for both (I think).

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/95f310fa27bb

->fixed

Comment 5

[Aakash Desai [:aakashd]]

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/95f310fa27bb

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090416 Minefield/3.6a1pre ID:20090416030845

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090417 Shiretoko/3.5b4pre ID:20090417030722