Closed Bug 454411 Opened 16 years ago Closed 16 years ago

[FIX]Redirects no longer cached

Categories

(Core :: Networking: HTTP, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jeresig, Assigned: bzbarsky)

References

()

Details

Attachments

(1 file)

Steve Souders found a regression from Firefox 2 to Firefox 3 where redirects are no longer cached (thus being requeried on every request). This appears to still be the case in the latest nightlies.

A reduced test case can be found here:
http://stevesouders.com/tests/test-cache-prime.php
This is a regression from bug 335909, since redirects have mStatus == NS_BINDING_REDIRECTED, which is a failure status.
Blocks: 335909
Flags: blocking1.9.1?
Summary: Redirects no longer cached → [FIX]Redirects no longer cached
Attached patch FixSplinter Review
Attachment #337687 - Flags: superreview?(cbiesinger)
Attachment #337687 - Flags: review?(cbiesinger)
Comment on attachment 337687 [details] [diff] [review]
Fix

+// Need to randomize, because apparently no one clears our cache

we probably should delete that before running each test. of course you only get a disk cache in debug builds anyway... (for xpcshell)
Attachment #337687 - Flags: superreview?(cbiesinger)
Attachment #337687 - Flags: superreview+
Attachment #337687 - Flags: review?(cbiesinger)
Attachment #337687 - Flags: review+
Pushed changeset 9c0c1804d4b7.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: blocking1.9.1? → in-testsuite+
Resolution: --- → FIXED
Depends on: 454587
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: