454570 - nsSearchService.js stores document and element on its global object

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

nsSearchService.js stores a document and an element on its global object because of missing |var|s. We're keeping those objects alive for the duration of the app with no reason. It might also cause leaks so we should probably also land this on branch.
Note that this will definitely cause leaks once bug 335998 has landed.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 337862 [details] [diff] [review]
v1

doh!

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 337862 [details] [diff] [review]
v1

This is a trivial fix, it makes debugging leaks easier and it might avoid some leaks.

Comment 3

[Daniel Veditz [:dveditz]]

This technically doesn't match the new branch criteria and there's no way to test/verify it. On the other hand adding "var " is braindead simple. mconnor?

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 337862 [details] [diff] [review]
v1

Approved for 1.9.0.4, a=dveditz for release-drivers

Comment 5

[Peter Van der Beken [:peterv]]

Checked in for 1.9.0.4.