454595 - textboxes accept any dropped data

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Neil Deakin]

Textboxes should only accept text or text-like dragged data (or files for input type="file"). Right now, code at http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/nsEditorEventListeners.cpp#578 is always canceling the dragover event which in new-spec-land means allow a drop.

Comment 1

[Neil Deakin]

Attachment: move preventDefault to only occur when a drop is allowed

To reproduce this bug:

1. Drag something that doesn't have text data. For example, in Firefox, the items in the Manage Search Engines list. (Looks like attachments in Thunderbird might do this too, not sure).
2. Drag it onto a textbox. Note that the data seems to be droppable on the textbox even though it shouldn't be allowed.

In the dnd spec, cancelling the dragover event is the way to accept a drop, so we need to ensure that the editor only cancels the event in this case.

Comment 2

[Marco Bonardo [:mak]]

i was looking around for the push changeset :) here it is:
http://hg.mozilla.org/mozilla-central/rev/ecb32d66071e