454664 - Events not displayed after opening/subscribing iCalendar file - manual reload required

Status: VERIFIED FIXED

(Calendar :: Provider: ICS/WebDAV, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18pre) Gecko/2008090921 Sunbird/0.9

Steps to Reproduce:
1. Start Sunbird using a clean profile
2. Download an iCalendar file to local disk, e.g. from
   <http://www.mozilla.org/projects/calendar/holidays.html>
3. Open the downloaded .ics file via menu File -> Open Calendar File

Actual Results:
Events and tasks from the file are not shown in Sunbird. It's necessary to execute File -> Reload Remote Calendars to make them visible.

Expected Results:
Events and tasks from the file are shown immediately after opening the file.

Comment 1

[Stefan Sitter [:ssitter]]

Issue also happens when directly subscribing to the remote iCalendar file.

Regression range: Works in Sunbird 0.9 (2008-09-06-20)
                  Fails in Sunbird 0.9 (2008-09-07-20)
                  
Checkins during regression range: http://tinyurl.com/6xoglu

Might be regressed by Bug 453250.

Comment 2

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

Refreshes calendars being registered (if possibly).

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v2

This patch contains my review comments.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH and SUNBIRD_0_9_BRANCH

-> FIXED

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

comment: v1 doesn't fix refreshing when a calendar is enabled that has always been disabled. I've fixed that in v2.

Comment 6

[Stefan Sitter [:ssitter]]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18pre) Gecko/2008091218 Sunbird/0.9.