454674 - Re-theme the navigation screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Madhava Enros [:madhava]]

Currently, its look is based on my wireframes.  We should theme it according to
the working theme.  I'm working with Sean to get icons, etc.  It will be along these lines:

http://blog.seanmartell.com/wp-content/uploads/2008/09/fennec_screen_8.jpg

Comment 1

[Madhava Enros [:madhava]]

Attachment: sliced images for the navigation screen

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This required editing of nav_caps, such that the top cap was on top of bottom one (for use with -moz-border-image), and had to split search_caps into two separate images (nav_search_left and nav_search_right).

I also did some other renames so that these fit in with the existing files:
background_mask -> nav_background_mask
navigation_icons -> nav_icons
search_middle -> nav_search_middle

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: real patch

Comment 4

[:Gavin Sharp [email: [e-mail]]]

This is super slow on the device - it takes like 1-2s just for the images to show up :(

Comment 5

[Stuart Parmenter]

if we make the window non-transparent how does it perform?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Making the <panel> non-transparent doesn't really help. It appears to be the actual images loading that takes a long time. There are 7 different images used here - ideally we could reduce that but it might mean changing the appearance a little bit...

Comment 7

[Madhava Enros [:madhava]]

Attachment: full star (ie, bookmarked)

for use in the awesomebar result-set for bookmarked pages

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Reduces the number of images/elements by using border-image. Transparency isn't working because the richlistbox breaks it, I'll need to file a layout bug on that I think.

This can be extended to also cover the navigation screen with the same style, but doing that results in strange glitches that look like they might also be bugs, need to investigate more. See XXX comments in patch.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: correct patch

The XXX comment was at the wrong place in the other patch.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Attachment: correct patch, against tip

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 342201 [details] [diff] [review]
correct patch, against tip

In the future, we should think about upscaling the favicons a little.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Attachment: with bigger font

per madhava

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Attachment: and minheight on the bottom searchbar

Comment 14

[Madhava Enros [:madhava]]

Attachment: small magnifyer icon for the search area

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Attachment: with magnifier image

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Landed:
http://hg.mozilla.org/mobile-browser/rev/15c6534f0123

Comment 17

[Joel Maher ( :jmaher ) (UTC -8)]

verfied with beta3