454703 - WinCE Compiler Missing Values and APIs or Redefined Values

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Patch file for WinCE shunt header file

The values EINVAL and ERANGE are used by mozilla-central code, but not in the WinMobile headers.  These values are also not yet defined in the WinCE mozce_shunt.h header file.

Microsoft, in their infinite wisdom, decided to make Wide and Char versions of the structure SHELLEXECUTEINFO -- and define the Wide version as SHELLEXECUTEINFOW for the desktop.  For WinMobile, the SHELLEXECUTEINFO structure IS exactly the desktop's Wide version.  Added some mozce_shunt.h defines to map SHELLEXECUTEINFOW to SHELLEXECUTEINFO for WinCE, and the function ShellExecuteExW() as ShellExecuteEx().

VERIFY macro is being re-defined in widget module, causing compiler failure under WinCE build.  So this patch file undefines VERIFY if defined -- causing the redefinition to proceed without failure.

COLOR_HOTLIGHT is not properly defined in WinMobile headers (API says value is 26 -- but WinMobile headers set it to COLOR_STATICTEXT), so added proper definition within nsLookAndFeel.cpp source file.

Added missing defines for AC_SRC_ALPHA, WS_EX_LAYERED, and ULW_ALPHA to widget module's nsWindow.cpp source file.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 337988 [details] [diff] [review]
Patch file for WinCE shunt header file

the widget/src/windows/nsWindow.cpp should either be in another bug, or lets just support this in the shunt.

Comment 2

[Doug Turner (:dougt)]

As I mentioned, the build/wince stuff is fine, just not the window widget stuff.  Please move those into a different bug (or better yet, fix up the shunt to handle them).  I am pushing the shunt pieces.

changeset:   19518:1430f10b4c45
tag:         tip
user:        Doug Turner <[e-mail]>
date:        Mon Sep 22 21:37:50 2008 +0100
summary:     Bug 454703 - WinCE Compiler Missing Values and APIs or Redefined Values.  Patch by Wolfe, r=dougt