Closed
Bug 454743
Opened 16 years ago
Closed 16 years ago
skip empty glyphs rather than rendering as spaces
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
|
8.05 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Pango shapers return PANGO_GLYPH_EMPTY glyphs for characters "that should not
be normally rendered on the screen". Currently we render these with the space
glyph. A better approach is to not render them at all.
|
Assignee | |
Comment 1•16 years ago
|
||
This simplifies some APIs, making things easier for bug 385263.
Attachment #338051 -
Flags: review?(roc)
Comment on attachment 338051 [details] [diff] [review]
skip empty glyphs
Nice. Could we have a simple reftest for these characters?
Attachment #338051 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> Could we have a simple reftest for these characters?
The single-empty-glyph-cluster case is tested by ZWNJ in bugs/421234-1.html and text/zwnj-01.html.
I added a test that the combining grapheme joiner U+034F is not visible and has no format effect, to test a multiglyph cluster.
http://hg.mozilla.org/mozilla-central/rev/c8269b148c83
|
|
Assignee | |
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
|
Assignee | |
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•