skip empty glyphs rather than rendering as spaces

RESOLVED FIXED in mozilla1.9.1b1

Status

()

Core
Graphics
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

Trunk
mozilla1.9.1b1
x86
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Pango shapers return PANGO_GLYPH_EMPTY glyphs for characters "that should not
be normally rendered on the screen".  Currently we render these with the space
glyph.  A better approach is to not render them at all.
(Assignee)

Comment 1

9 years ago
Created attachment 338051 [details] [diff] [review]
skip empty glyphs

This simplifies some APIs, making things easier for bug 385263.
Attachment #338051 - Flags: review?(roc)
Comment on attachment 338051 [details] [diff] [review]
skip empty glyphs

Nice. Could we have a simple reftest for these characters?
Attachment #338051 - Flags: review?(roc) → review+
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> Could we have a simple reftest for these characters?

The single-empty-glyph-cluster case is tested by ZWNJ in bugs/421234-1.html and text/zwnj-01.html.

I added a test that the combining grapheme joiner U+034F is not visible and has no format effect, to test a multiglyph cluster.

http://hg.mozilla.org/mozilla-central/rev/c8269b148c83
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/31585e357fa3
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.