Closed Bug 454786 Opened 11 years ago Closed 11 years ago

Configuration Changes to allow WinCE resource and assembly compiling

Categories

(Firefox Build System :: General, defect)

ARM
Windows Mobile 6 Professional
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wolfe, Assigned: wolfe)

References

Details

(Keywords: mobile)

Attachments

(1 file, 1 obsolete file)

No description provided.
This patch is located in a WINCE-only section of the configure.in file.

This patch puts any mozconfig-specified AS back into place (AS forcibly set to $(CC) on line 940 of configure.in).

This patch also sets RC to "rc.exe" ONLY if no RC has already been set.  This change allows a mozconfig-specified RC, while still leaving the old behavior if RC has not been specified in a mozconfig file.
Attachment #338090 - Flags: review?(doug.turner)
Darn Firefox browser - I hit a back arrow that somehow got converted into a return.  Sorry for the extra emails.
OS: Windows XP → Windows Mobile 6 Professional
Hardware: PC → PocketPC
Attachment #338090 - Flags: review?(ted.mielczarek)
Attachment #338090 - Flags: review?(doug.turner)
Attachment #338090 - Flags: review?
Comment on attachment 338090 [details] [diff] [review]
Configure.in changes to allow mozconfig specification of AS and RC

ted should look at this.

I am not sure that this is the best place for this set, but if it isn't ted will know!!
Assignee: nobody → wolfe
Flags: blocking-fennec1.0+
Target Milestone: --- → Fennec A2
Attachment #338090 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 338090 [details] [diff] [review]
Configure.in changes to allow mozconfig specification of AS and RC

-    RC=rc.exe
+    if test -n "$RC"; then 
+        RC=rc.exe  
+    fi

You want "test -z" here.
Ted and Doug - just replaced the '-n' test flag with '-z', as per ted's comment on the previous attached patch file.
Attachment #338090 - Attachment is obsolete: true
Attachment #338660 - Flags: review?(ted.mielczarek)
Attachment #338090 - Flags: review?
Attachment #338660 - Flags: review?(ted.mielczarek) → review+
Added mobile and checkin-needed flags to this bug.
Blocks: 432792
Comment on attachment 338660 [details] [diff] [review]
Configure.in changes to allow mozconfig specification of AS and RC - using -z instead of -n
[Checkin: Comment 7]

http://hg.mozilla.org/mozilla-central/rev/9ee685755478
Attachment #338660 - Attachment description: Configure.in changes to allow mozconfig specification of AS and RC - using -z instead of -n → Configure.in changes to allow mozconfig specification of AS and RC - using -z instead of -n [Checkin: Comment 7]
(In reply to comment #7)
> (From update of attachment 338660 [details] [diff] [review])

Note that (this) patch should have had Linux EOL, not Windows EOL.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Component: General → Build Config
Product: Fennec → Core
QA Contact: general → build-config
Target Milestone: Fennec A2 → ---
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.