Closed
Bug 454797
Opened 16 years ago
Closed 16 years ago
WinCE GFX Cairo No MMX Support in ARM
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wolfe, Assigned: wolfe)
References
Details
(Keywords: mobile)
Attachments
(1 file)
|
541 bytes,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
WinCE ARM devices have no MMX support - this patch disables MMX support for WinCE builds.
Attachment #338099 -
Flags: review?(vladimir)
Oh wow, I had completely forgotten we were using MSVC-on-ARM there. So that patch is fine, but I think we'll also want the pixman-arm bits (especially there, where our rendering will be software). But those bits are using inline gcc assembly -- could you work with Jeff to get those converted into MSVC inline assembly, behind #ifdefs?
Attachment #338099 -
Flags: review?(vladimir) → review+
|
||
Comment 2•16 years ago
|
||
As far as I can tell MSVC on ARM does not support inline assembly this means we'll have to target 'armasm' which will be harder.
Harder? You mean EXCITING!
|
|
||
Comment 4•16 years ago
|
||
You're right, I do mean that.
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 5•16 years ago
|
||
Comment on attachment 338099 [details] [diff] [review]
Disables MMX support for WinCE builds
[Checkin: Comment 5]
http://hg.mozilla.org/mozilla-central/rev/e3f57277e577
***
Note that patch should have Unix EOL.
Attachment #338099 -
Attachment description: Disables MMX support for WinCE builds → Disables MMX support for WinCE builds
[Checkin: Comment 5]
|
|
||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Assignee: nobody → wolfe
|
||
Updated•16 years ago
|
Component: General → GFX: Thebes
Product: Fennec → Core
QA Contact: general → thebes
You need to log in
before you can comment on or make changes to this bug.
Description
•