454865 - memory usage regression (working set/rss), 09-09-2008

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Robert Sayre]

Across the board increase.

Comment 1

[Robert Sayre]

Attachment: regression on 5 machines

Comment 2

[Joe Drew (not getting mail)]

Boris has some checkins around this time.

Comment 3

[Boris Zbarsky [:bzbarsky]]

What's the pushlog range here?  What is this test measuring, exactly?

Comment 4

[Robert Sayre]

Range is 9/9/2008 5:45pm -0700 / 9/9/2008 7:01pm -0700

Comment 5

[Boris Zbarsky [:bzbarsky]]

And what are we measuring?

Pushlog for that date range is http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-09-09+5%3A45%3A00&enddate=9%2F9%2F2008+7%3A01pm

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er, the correct pushlog url is http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-09-09+17%3A45%3A00&enddate=2008-09-09+19%3A01%3A00

If this is memory consumption after the talos run finishes, it might be that the issue is the docshell change...

Comment 7

[Robert Sayre]

working set
http://msdn.microsoft.com/en-us/library/ms684891(VS.85).aspx

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

XP and Vista

http://graphs.mozilla.org/#show=395024,395034,395054&sel=1220829489,1221157740
http://graphs.mozilla.org/#show=787147,787146,787108&sel=1220878181,1221146988

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

RSS is also up on the other platforms:

Ubuntu - http://graphs.mozilla.org/#show=395170,395139,395141&sel=1220883041,1221162120
OSX Tiger - http://graphs.mozilla.org/#show=394895,394915,394904&sel=1220932262,1221112865
OSX Leopard - http://graphs.mozilla.org/#show=794420,794419,794433&sel=1220980903,1221055523

--> All

Comment 10

[Robert Strong (they/them - no direct email)]

Just backed out bug 396519 to see if it is the cause

Comment 11

[Robert Strong (they/them - no direct email)]

Looks like the back out for bug 396519 has fixed this.

http://graphs.mozilla.org/graph.html#show=911694,911696,911698

Comment 12

[Robert Strong (they/them - no direct email)]

Mac OS X appears to be fixed as well

http://graphs.mozilla.org/graph.html#show=911655,911657,911659

Comment 13

[Robert Strong (they/them - no direct email)]

Windows is fixed as well... reopening the tree

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It also looks like there were pageload *time* spikes over the same time period.  See, e.g.,
Mac:
http://graphs.mozilla.org/graph.html#show=394872,394887,394900,911655,1431170&sel=1220899002,1221274013

Windows:
http://graphs.mozilla.org/graph.html#show=395008,395020,395048,912148,1431867&sel=1220843235,1221359925